From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2AE1A431FD0 for ; Mon, 5 Sep 2011 12:31:36 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KR+2iW2fLi30 for ; Mon, 5 Sep 2011 12:31:35 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id C4743431FB6 for ; Mon, 5 Sep 2011 12:31:35 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 7991F328200; Mon, 5 Sep 2011 12:31:35 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (cpe-76-166-145-155.socal.res.rr.com [76.166.145.155]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id B135D2E50D5C; Mon, 5 Sep 2011 12:31:32 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 4AEFFE3D; Mon, 5 Sep 2011 12:31:32 -0700 (PDT) From: Jameson Graef Rollins To: Thomas Schwinge , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch restore --accumulate In-Reply-To: <1315249637-20179-1-git-send-email-thomas@schwinge.name> References: <1315249637-20179-1-git-send-email-thomas@schwinge.name> User-Agent: Notmuch/0.7-41-g7dce23e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 05 Sep 2011 12:31:29 -0700 Message-ID: <87liu2kcq6.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2011 19:31:36 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 5 Sep 2011 21:07:17 +0200, Thomas Schwinge = wrote: > From: Thomas Schwinge >=20 > Also enhance the dump-restore testsuite, and make it generally more > failure-proof. Hi, Thomas. Your commit log doesn't describe what this patch does. If you're adding a new feature you should describe in detail what this new feature does and how it works. Also, we generally prefer to have modifications to the test suite in separate patches that precede the patches that add the features/fix the bugs. > Signed-off-by: Thomas Schwinge Finally, you don't need to sign off on your own patches. Thanks. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOZSOSAAoJEO00zqvie6q8f5UP/0ig2T/mmL/NY9gYx/8Pr5lJ vloZ30ke2yArMMghL1pmTwW6prKVgjjkAN/wCGvSiYZTMU1Uueg09ksYolO/flTY o0LZu6L6Oey0HhHgeqFEONrVHJAK3LOF0uJKicTQs72maLAUZoOZYzKUR5GyV02G N+a8yY3bc+P4kc87L6c5mdIfnEp9r6PcP+USiI0/BFqsnRgYwRaZI12nJbVzRZei JXEWhNqFyfZCNM7XX7mQs/vSQTcwF37lt5ItCsjhQfv74sy70HHaH2P9TE1i14qX fYLEKWm3XKmqOYpYRMKXLv/J6j9tPO15aHxZQtJoBdkY9tuC5lE7doDyCZtdrxus Ol+BmlrAQIxFdzMZYW3roWPNNyMJx+4JEXXov4CHh0vumnmyAwrOt1CK6tQBySsP itJJFLhV51Qlapz15gqxhVvvo/iHpPBKeDVm79JgNYnNWZFbKRwXzwQxoQl9w9lh HWNA+hkrbzIthn0PrPzLUwrfpNCdE/tv6z3M+ZAHBStZJRsultpUWpLUf6o8DcPn UhjfYyc1ZEStosQuFlHPa90m8TDw6Y8U2LxqRp4o3Jv1CmtyTydc3GzAT5gW/QcZ svC01zQdANj4384CQgd3OT2tOroe0+YN7ZmtoGJt3m3thgYmxPAXXvHBzqhAs5eh AOwAdTwqM5b9x9Sm5p/7 =vGVt -----END PGP SIGNATURE----- --=-=-=--