From: Austin Clements <amdragon@MIT.EDU>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show
Date: Sun, 27 Nov 2011 21:30:11 -0500 [thread overview]
Message-ID: <87lir12d3g.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com>
Both patches look good to me.
(I don't think the compiler could warn about the unused `headers'
binding even if it wanted to because of dynamic scoping.)
next prev parent reply other threads:[~2011-11-28 2:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 22:23 [PATCH 1/2] emacs: remove some code duplication in notmuch-show Dmitry Kurochkin
2011-11-25 22:23 ` [PATCH 2/2] emacs: remove unused variable in `notmuch-show-insert-part-message/rfc822' Dmitry Kurochkin
2011-11-28 2:30 ` Austin Clements [this message]
2011-11-28 14:24 ` [PATCH 1/2] emacs: remove some code duplication in notmuch-show Jameson Graef Rollins
2011-11-28 18:11 ` Dmitry Kurochkin
2011-11-28 18:28 ` Austin Clements
2011-11-28 19:51 ` Jameson Graef Rollins
2011-12-07 15:14 ` Dmitry Kurochkin
2011-12-08 1:02 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lir12d3g.fsf@awakening.csail.mit.edu \
--to=amdragon@mit.edu \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).