From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E6237429E26 for ; Thu, 12 Jan 2012 09:08:47 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LBRlh+mdOBNp for ; Thu, 12 Jan 2012 09:08:47 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 303C9431FB6 for ; Thu, 12 Jan 2012 09:08:47 -0800 (PST) Received: by wgbds11 with SMTP id ds11so1946254wgb.2 for ; Thu, 12 Jan 2012 09:08:46 -0800 (PST) Received: by 10.181.11.163 with SMTP id ej3mr7782597wid.4.1326388125929; Thu, 12 Jan 2012 09:08:45 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id v28sm6434502wbo.18.2012.01.12.09.08.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:08:45 -0800 (PST) From: Pieter Praet To: Thomas Jost , notmuch@notmuchmail.org Subject: Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" In-Reply-To: <87aa7vawek.fsf@thor.loria.fr> References: <1320176954-4897-1-git-send-email-pieter@praet.org> <1321454035-22023-1-git-send-email-schnouki@schnouki.net> <8739dneqra.fsf@praet.org> <87aa7vawek.fsf@thor.loria.fr> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:07:06 +0100 Message-ID: <87lipcluit.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:08:48 -0000 On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost wrote: > On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet wrote: > > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost wrote: > > > Hello list, > > > > > > This is another rebased version of Pieter's series to add GPG and Emacs as test > > > prereqs, plus some additions on my own. (Rebased and posted as requested by > > > Pieter [1].) > > > > > > > Thanks Thomas! > > > > Although... you may have misread (or maybe I mistyped :), but what I > > actually intended [1] was for you to rebase *only* your fixes on top of > > my rebased series (e.g. see "tjost-fixes.patch" in att), so you could > > receive proper credit for cleaning up my mess. > > Oh, ok, I must have misread that :) > > Right now your patches don't apply cleanly on master (conflict in patch > 3 due to commit 5964a7), and I think that Dmitry's patches [1] may be a > better way to handle prereqs. So I probably won't send those patches > until we decide which approach is the way to go. > > [1] id:"1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com" > Yup, Dmitry's solution is much more elegant! > > Also, while my apprehension [2,3] re the inclusion of the SCREEN/DTACH > > prereq in patches #4,5,6 didn't have much merit (it's an all-or-nothing > > affair anyways), the issue [3] in patch #5 @ "Reply within emacs" still > > stands: `sed' will run unconditionally, and treat "EMACS" as an input > > file. (see "sed-prereq-fix.patch" in att). > > Nice catch with this sed issue. Looks like I need to be more careful > when replacing "OUTPUT" with "EMACS OUTPUT"... > > Thanks, > > -- > Thomas/Schnouki Peace -- Pieter