From: Pieter Praet <pieter@praet.org>
To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs"
Date: Thu, 12 Jan 2012 18:07:06 +0100 [thread overview]
Message-ID: <87lipcluit.fsf@praet.org> (raw)
In-Reply-To: <87aa7vawek.fsf@thor.loria.fr>
On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
> On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet <pieter@praet.org> wrote:
> > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
> > > Hello list,
> > >
> > > This is another rebased version of Pieter's series to add GPG and Emacs as test
> > > prereqs, plus some additions on my own. (Rebased and posted as requested by
> > > Pieter [1].)
> > >
> >
> > Thanks Thomas!
> >
> > Although... you may have misread (or maybe I mistyped :), but what I
> > actually intended [1] was for you to rebase *only* your fixes on top of
> > my rebased series (e.g. see "tjost-fixes.patch" in att), so you could
> > receive proper credit for cleaning up my mess.
>
> Oh, ok, I must have misread that :)
>
> Right now your patches don't apply cleanly on master (conflict in patch
> 3 due to commit 5964a7), and I think that Dmitry's patches [1] may be a
> better way to handle prereqs. So I probably won't send those patches
> until we decide which approach is the way to go.
>
> [1] id:"1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com"
>
Yup, Dmitry's solution is much more elegant!
> > Also, while my apprehension [2,3] re the inclusion of the SCREEN/DTACH
> > prereq in patches #4,5,6 didn't have much merit (it's an all-or-nothing
> > affair anyways), the issue [3] in patch #5 @ "Reply within emacs" still
> > stands: `sed' will run unconditionally, and treat "EMACS" as an input
> > file. (see "sed-prereq-fix.patch" in att).
>
> Nice catch with this sed issue. Looks like I need to be more careful
> when replacing "OUTPUT" with "EMACS OUTPUT"...
>
> Thanks,
>
> --
> Thomas/Schnouki
Peace
--
Pieter
prev parent reply other threads:[~2012-01-12 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 19:49 set test prereqs (Emacs, GDB, GPG) v4 Pieter Praet
2011-11-01 19:49 ` [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests Pieter Praet
2011-11-01 21:17 ` Jameson Graef Rollins
2011-11-02 17:20 ` Pieter Praet
2011-11-01 19:49 ` [PATCH 2/4] test: add 'Emacs' " Pieter Praet
2011-11-01 19:49 ` [PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests Pieter Praet
2011-11-01 19:49 ` [PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests Pieter Praet
2011-11-01 20:20 ` set test prereqs (Emacs, GDB, GPG) v4 Ali Polatel
2011-11-02 17:21 ` Pieter Praet
2011-11-16 14:33 ` [PATCH 0/6] Rebase of Pieter's "set test prereqs" Thomas Jost
2011-11-16 14:33 ` [PATCH 1/6] test: define a helper function for defining prereqs on executables Thomas Jost
2011-11-16 14:33 ` [PATCH 2/6] test: check if emacs and dtach are available in test_emacs() Thomas Jost
2011-11-16 14:33 ` [PATCH 3/6] test: add 'GnuPG' prereq to dependent 'crypto' tests Thomas Jost
2011-11-16 14:33 ` [PATCH 4/6] test: add 'Emacs' " Thomas Jost
2011-11-16 14:33 ` [PATCH 5/6] test: add 'Emacs' prereq to dependent 'emacs' tests Thomas Jost
2011-11-16 14:33 ` [PATCH 6/6] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests Thomas Jost
2011-11-16 18:53 ` [PATCH 0/6] Rebase of Pieter's "set test prereqs" Jameson Graef Rollins
2011-11-16 20:17 ` Thomas Jost
2011-11-16 20:50 ` Pieter Praet
2011-11-17 10:14 ` Thomas Jost
2012-01-12 17:07 ` Pieter Praet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lipcluit.fsf@praet.org \
--to=pieter@praet.org \
--cc=notmuch@notmuchmail.org \
--cc=schnouki@schnouki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).