From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.
Date: Sat, 04 Feb 2012 19:59:58 +0200 [thread overview]
Message-ID: <87lioio4wx.fsf@nikula.org> (raw)
In-Reply-To: <1328375350-10352-2-git-send-email-markwalters1009@gmail.com>
On Sat, 4 Feb 2012 17:09:09 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> Add an option --from= to notmuch-reply.c to restrict guessing of the
> From: header. The existing logic looks as the main headers, then at
> the delivery headers, and finally defaults to the config file address.
>
> This patch allows the user to restrict which of these guesses are
> made. Currently the supported values are:
> default|fallback-all current behaviour
> fallback-received fallback to delivery headers but not config file
> fallback-none only look at from/reply-to/to/cc/ headers
> none From: header is always left empty
As discussed on IRC, --from=primary is a natural extension to always use
the primary address from config, but that can be a later patch.
>
> If the code does not find an allowed address it outputs an empty From:
> line and the caller can decide how to respond.
> ---
> notmuch-reply.c | 39 ++++++++++++++++++++++++++++++---------
> 1 files changed, 30 insertions(+), 9 deletions(-)
>
> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index f55b1d2..f660749 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -24,6 +24,13 @@
> #include "gmime-filter-reply.h"
> #include "gmime-filter-headers.h"
>
I think it would be good to have a comment here reminding later
developers that the order matters in this enum.
> +enum {
> + FROM_FALLBACK_ALL,
> + FROM_FALLBACK_RECEIVED,
> + FROM_FALLBACK_NONE,
> + FROM_NONE
> +};
> +
> static void
> reply_headers_message_part (GMimeMessage *message);
>
> @@ -510,7 +517,8 @@ notmuch_reply_format_default(void *ctx,
> notmuch_config_t *config,
> notmuch_query_t *query,
> notmuch_show_params_t *params,
> - notmuch_bool_t reply_all)
> + notmuch_bool_t reply_all,
> + int from_guess)
Hrmh, I'd like this to sound more deterministic than
"guessing". from_select? from_use? from?
> {
> GMimeMessage *reply;
> notmuch_messages_t *messages;
> @@ -542,15 +550,19 @@ notmuch_reply_format_default(void *ctx,
> from_addr = add_recipients_from_message (reply, config, message,
> reply_all);
>
> - if (from_addr == NULL)
> + if ((from_addr == NULL) && (from_guess <= FROM_FALLBACK_RECEIVED))
Please drop the extra braces here and below.
> from_addr = guess_from_received_header (config, message);
>
> - if (from_addr == NULL)
> + if ((from_addr == NULL) && (from_guess <= FROM_FALLBACK_ALL ))
> from_addr = notmuch_config_get_user_primary_email (config);
>
> - from_addr = talloc_asprintf (ctx, "%s <%s>",
> - notmuch_config_get_user_name (config),
> - from_addr);
> + if ((from_addr != NULL) || (from_guess = FROM_NONE)) {
Should that be (from_addr != NULL && from_guess != FROM_NONE)?
Definitely the assignment is an error!
> + from_addr = talloc_asprintf (ctx, "%s <%s>",
> + notmuch_config_get_user_name (config),
> + from_addr);
> + } else {
> + from_addr = talloc_strdup (ctx, "");
> + }
> g_mime_object_set_header (GMIME_OBJECT (reply),
> "From", from_addr);
>
> @@ -590,7 +602,8 @@ notmuch_reply_format_headers_only(void *ctx,
> notmuch_config_t *config,
> notmuch_query_t *query,
> unused (notmuch_show_params_t *params),
> - notmuch_bool_t reply_all)
> + notmuch_bool_t reply_all,
> + unused (int from_guess))
> {
> GMimeMessage *reply;
> notmuch_messages_t *messages;
> @@ -657,10 +670,11 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])
> notmuch_query_t *query;
> char *query_string;
> int opt_index, ret = 0;
> - int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params, notmuch_bool_t reply_all);
> + int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params, notmuch_bool_t reply_all, int from_guess);
> notmuch_show_params_t params = { .part = -1 };
> int format = FORMAT_DEFAULT;
> int reply_all = TRUE;
> + int from_guess = FROM_FALLBACK_ALL;
> notmuch_bool_t decrypt = FALSE;
>
> notmuch_opt_desc_t options[] = {
> @@ -672,6 +686,13 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])
> (notmuch_keyword_t []){ { "all", TRUE },
> { "sender", FALSE },
> { 0, 0 } } },
> + { NOTMUCH_OPT_KEYWORD, &from_guess, "from", 'F',
> + (notmuch_keyword_t []){ { "default", FROM_FALLBACK_ALL },
> + { "fallback-all", FROM_FALLBACK_ALL },
> + { "fallback-received", FROM_FALLBACK_RECEIVED },
> + { "fallback-none", FROM_FALLBACK_NONE },
> + { "none", FROM_NONE },
> + { 0, 0 } } },
> { NOTMUCH_OPT_BOOLEAN, &decrypt, "decrypt", 'd', 0 },
> { 0, 0, 0, 0, 0 }
> };
> @@ -732,7 +753,7 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])
> return 1;
> }
>
> - if (reply_format_func (ctx, config, query, ¶ms, reply_all) != 0)
> + if (reply_format_func (ctx, config, query, ¶ms, reply_all, from_guess) != 0)
> return 1;
>
> notmuch_query_destroy (query);
> --
> 1.7.2.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-02-04 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 17:09 [PATCH 0/2] Control guessing of the from-address when replying Mark Walters
2012-02-04 17:09 ` [PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header Mark Walters
2012-02-04 17:59 ` Jani Nikula [this message]
2012-02-04 19:07 ` Mark Walters
2012-02-04 17:09 ` [PATCH 2/2] emacs: Improve prompting for user address when replying Mark Walters
2012-02-04 18:03 ` Jani Nikula
2012-02-04 19:12 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lioio4wx.fsf@nikula.org \
--to=jani@nikula.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).