unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org, David Bremner <david@tethera.net>
Subject: Re: [PATCH v2 2/2] emacs: support text/calendar mime type
Date: Tue, 21 Feb 2012 07:52:54 +0000	[thread overview]
Message-ID: <87linwipwp.fsf@nikula.org> (raw)
In-Reply-To: <25a7cebf4b36e42f8232e34f86d7b5379d1d1959.1328798471.git.jani@nikula.org>

On Thu,  9 Feb 2012 14:46:03 +0000, Jani Nikula <jani@nikula.org> wrote:
> Replace text/x-vcalendar with text/calendar, while maintaining support
> and backwards compatibility for text/x-vcalendar.

David (B, not E), while 1/2 needs work, this 2/2 is independent and IMHO
could go in.

BR,
Jani.


> 
> Code by David Edmondson <dme@dme.org>
> ---
>  emacs/notmuch-show.el |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 5f643f1..33a4f18 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -711,7 +711,7 @@ current buffer, if possible."
>  	(run-hook-with-args 'notmuch-show-insert-text/plain-hook msg depth))))
>    t)
>  
> -(defun notmuch-show-insert-part-text/x-vcalendar (msg part content-type nth depth declared-type)
> +(defun notmuch-show-insert-part-text/calendar (msg part content-type nth depth declared-type)
>    (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename))
>    (insert (with-temp-buffer
>  	    (insert (notmuch-show-get-bodypart-content msg part nth))
> @@ -729,6 +729,10 @@ current buffer, if possible."
>  	      result)))
>    t)
>  
> +;; For backwards compatibility.
> +(defun notmuch-show-insert-part-text/x-vcalendar (msg part content-type nth depth declared-type)
> +  (notmuch-show-insert-part-text/calendar msg part content-type nth depth declared-type))
> +
>  (defun notmuch-show-insert-part-application/octet-stream (msg part content-type nth depth declared-type)
>    ;; If we can deduce a MIME type from the filename of the attachment,
>    ;; do so and pass it on to the handler for that type.
> -- 
> 1.7.1
> 

  parent reply	other threads:[~2012-02-21  7:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 16:55 [PATCH 0/2] multipart/alternative display and text/calendar Jani Nikula
2012-02-08 16:55 ` [PATCH 1/2] emacs: support defining a list of alternative parts to show Jani Nikula
2012-02-08 17:05   ` David Edmondson
2012-02-08 16:55 ` [PATCH 2/2] emacs: regard text/calendar as text/x-vcalendar Jani Nikula
2012-02-08 17:06   ` David Edmondson
2012-02-09 14:46 ` [PATCH v2 1/2] emacs: support defining a list of alternative parts to show Jani Nikula
2012-02-09 14:46   ` [PATCH v2 2/2] emacs: support text/calendar mime type Jani Nikula
2012-02-10 10:06     ` David Edmondson
2012-02-15 15:35     ` Adam Wolfe Gordon
2012-02-21  7:52     ` Jani Nikula [this message]
2012-02-25 13:55     ` David Bremner
2012-02-10 10:05   ` [PATCH v2 1/2] emacs: support defining a list of alternative parts to show David Edmondson
2012-02-10 10:17     ` Jani Nikula
2012-02-12 12:09     ` Jani Nikula
2012-02-12 14:37       ` Tomi Ollila
2012-02-21  7:50   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87linwipwp.fsf@nikula.org \
    --to=jani@nikula.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).