From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message API
Date: Mon, 30 Apr 2012 08:53:47 -0300 [thread overview]
Message-ID: <87lildph9w.fsf@zancas.localnet> (raw)
In-Reply-To: <1335649518-1970-1-git-send-email-amdragon@mit.edu>
Austin Clements <amdragon@MIT.EDU> writes:
> The signature of notmuch_database_find_message was changed in 02a30767
> to report errors and the Go bindings were never updated. This brings
> the Go bindings in sync with that change and at least makes them
> compile with Go r60.3, the last release before Go 1.
I don't have any easy way to test this, since the current versions in
Debian are all based on Go 1. On the other hand I guess it doesn't make
things worse. Anybody have any objections to this patch?
In the long run we have to decide what to do about these bindings. Seb
(or anyone else) are you interested in porting them to Go 1 and
maintaining them? Otherwise it may be time to deprecate them.
d
next prev parent reply other threads:[~2012-04-30 11:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 21:45 [PATCH] go: Update to the current notmuch_database_find_message API Austin Clements
2012-04-30 11:53 ` David Bremner [this message]
2012-04-30 19:54 ` Justus Winter
2012-04-30 19:55 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-04-30 19:55 ` [PATCH 2/5] go: set LDFLAGS, fix include directive Justus Winter
2012-04-30 19:55 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-04-30 19:55 ` [PATCH 4/5] go: update the build system Justus Winter
2012-04-30 19:55 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-04 18:38 ` [PATCH 1/5] go: reorganize the go bindings Austin Clements
2012-05-04 18:43 ` Austin Clements
2012-05-05 11:15 ` Justus Winter
2012-05-09 11:15 ` [patch v2] update the go stuff to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-05-09 11:15 ` [PATCH 2/5] go: set LDFLAGS to -lnotmuch in the packages source file Justus Winter
2012-05-09 11:15 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 4/5] go: update the build system Justus Winter
2012-05-09 11:15 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-09 18:10 ` [patch v2] update the go stuff to go 1 Austin Clements
2012-05-11 11:48 ` David Bremner
2012-04-30 20:14 ` [PATCH] go: Update to the current notmuch_database_find_message API Sebastien Binet
2012-05-04 11:56 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lildph9w.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).