From: Austin Clements <aclements@csail.mit.edu>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [Patch v2 04/11] perf-test: optionally print description for each group of tests
Date: Mon, 10 Dec 2012 23:31:15 -0500 [thread overview]
Message-ID: <87lid5nrak.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1354762908-5788-5-git-send-email-david@tethera.net>
On Wed, 05 Dec 2012, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> Output from tests is indented slightly in the same style as the
> correctness tests.
> ---
> performance-test/perf-test-lib.sh | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/performance-test/perf-test-lib.sh b/performance-test/perf-test-lib.sh
> index e399d3f..415bf15 100644
> --- a/performance-test/perf-test-lib.sh
> +++ b/performance-test/perf-test-lib.sh
> @@ -67,12 +67,12 @@ add_email_corpus ()
> }
>
> print_header () {
> - printf "[v%4s %6s] Wall(s)\tUsr(s)\tSys(s)\tRes(K)\tIn/Out(512B)\n" \
> + printf "[v%4s %6s] Wall(s)\tUsr(s)\tSys(s)\tRes(K)\tIn/Out(512B)\n" \
> ${PERFTEST_VERSION} ${corpus_size}
> }
>
> time_run () {
> - printf "%-22s" "$1"
> + printf " %-22s" "$1"
> if test "$verbose" != "t"; then exec 4>test.output 3>&4; fi
> if ! eval >&3 "/usr/bin/time -f '%e\t%U\t%S\t%M\t%I/%O' $2" ; then
> test_failure=$(($test_failure + 1))
> @@ -92,3 +92,8 @@ time_done () {
>
> cd -P "$test" || error "Cannot setup test environment"
> test_failure=0
> +
> +if [[ -n "test_description" ]]; then
I think you meant "$test_description". Though, it seems like it would
be confusing if $test_description wasn't set and there was no output.
Maybe this shouldn't be conditional and below should be
${test_description:-UNNAMED} or something?
> + echo
> + echo $(basename "$0"): "Benchmarking ${test_description}"
> +fi
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-12-11 4:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 3:01 Performance test improvements, v2 david
2012-12-06 3:01 ` [Patch v2 01/11] perf-test: propagate non-zero returns from /usr/bin/time david
2012-12-06 3:01 ` [Patch v2 02/11] perf-test: add argument parsing for performance tests david
2012-12-06 3:01 ` [Patch v2 03/11] perf-test: add corpus size to output, compact I/O stats david
2012-12-06 3:01 ` [Patch v2 04/11] perf-test: optionally print description for each group of tests david
2012-12-11 4:31 ` Austin Clements [this message]
2012-12-06 3:01 ` [Patch v2 05/11] perf-test: cache unpacked corpus david
2012-12-06 3:01 ` [Patch v2 06/11] perf-test: add caching of xapian database david
2012-12-06 3:01 ` [Patch v2 07/11] perf-test: update README david
2012-12-06 3:01 ` [Patch v2 08/11] perf-test: bump corpus version to 0.3 david
2012-12-06 3:01 ` [Patch v2 09/11] perf-test: unpack tags david
2012-12-06 3:01 ` [Patch v2 10/11] perf-test: split basic into 00-new and 01-dump-restore david
2012-12-11 4:50 ` Austin Clements
2012-12-06 3:01 ` [Patch v2 11/11] perf-test: use nmbug tags in dump-restore tests david
2012-12-11 4:52 ` Performance test improvements, v2 Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lid5nrak.fsf@awakening.csail.mit.edu \
--to=aclements@csail.mit.edu \
--cc=bremner@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).