From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 729E7431FAE for ; Wed, 26 Dec 2012 06:25:02 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fGUCPor3HENZ for ; Wed, 26 Dec 2012 06:25:02 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E1276431FAF for ; Wed, 26 Dec 2012 06:25:01 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Tnrul-0002TV-Eu; Wed, 26 Dec 2012 10:24:59 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1Tnrud-0005uN-Hl; Wed, 26 Dec 2012 10:24:51 -0400 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/5] util: Factor out boolean term quoting routine In-Reply-To: <1356493723-11085-2-git-send-email-amdragon@mit.edu> References: <1356493723-11085-1-git-send-email-amdragon@mit.edu> <1356493723-11085-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Dec 2012 10:24:51 -0400 Message-ID: <87lickrivg.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2012 14:25:02 -0000 Austin Clements writes: > +/* Construct a boolean term query with the specified prefix (e.g., > + * "id") and search term, quoting term as necessary. > + * > + * Output is into buf; it may be talloc_realloced. > + * Return: 0 on success, non-zero on memory allocation failure. > + */ > +int make_boolean_term (void *talloc_ctx, const char *prefix, const char *term, > + char **buf, size_t *len); > + I think the quoting should be described a bit more precisely here, especially since you are going to refer to it in the comment above parse_boolean_term. d