From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5F15F431FCB for ; Sun, 30 Jun 2013 09:30:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bDfLTrMuYiYX for ; Sun, 30 Jun 2013 09:30:48 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 3C8F2431FC2 for ; Sun, 30 Jun 2013 09:30:48 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1UtKWU-0003LT-1x; Sun, 30 Jun 2013 13:30:46 -0300 Received: (nullmailer pid 15010 invoked by uid 1000); Sun, 30 Jun 2013 16:30:42 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait In-Reply-To: <1372582512-10777-3-git-send-email-markwalters1009@gmail.com> References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com> <1372582512-10777-3-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sun, 30 Jun 2013 13:30:42 -0300 Message-ID: <87li5rtvbh.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2013 16:30:54 -0000 Mark Walters writes: > +(defvar notmuch-pick-open-target nil) > +(make-variable-buffer-local 'notmuch-pick-open-target) What do people think about adding a code style suggestion/requirement for elisp that all variables have docstrings, even if intended for internal use? It's true the existing code doesn't really meet this standard. > (defvar notmuch-pick-buffer-name nil) > (make-variable-buffer-local 'notmuch-pick-buffer-name) > ;; This variable is the window used for the message pane. It is set > @@ -349,8 +351,8 @@ Does NOT change the database." > (notmuch-pick (notmuch-search-find-thread-id) > notmuch-search-query-string > nil > - (notmuch-prettify-subject (notmuch-search-find-subject))) > - (notmuch-pick-show-match-message-with-wait)) > + (notmuch-prettify-subject (notmuch-search-find-subject)) > + t)) I think my previous complaint can be reformulated as (essentially) both notmuch-pick and notmuch-pick-open-target could use (better) docstrings. As you say, the hack removed is quite horrible, so I'd be willing to merge the patches anyway. OTOH, more documentation might make it so that more than one person can understand the notmuch-pick code. d