From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it
Date: Sat, 02 Nov 2013 09:14:21 -0300 [thread overview]
Message-ID: <87li17rof6.fsf@zancas.localnet> (raw)
In-Reply-To: <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> Adding another level is just useless cruft.
> ---
> lib/database.cc | 14 ++++----------
> notmuch-compact.c | 4 ++--
> 2 files changed, 6 insertions(+), 12 deletions(-)
The first two patches are fine, modulo my comments about documentation.
I think the backup path needs to be updated in notmuch-compact.c, and
possible the test updated (after applying
id:1383350515-24320-1-git-send-email-david@tethera.net)
d
next prev parent reply other threads:[~2013-11-02 12:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 14:27 [PATCH 0/6] compactor changes Jani Nikula
2013-11-01 14:27 ` [PATCH 1/6] lib: construct compactor within try block to catch any exceptions Jani Nikula
2013-11-01 14:27 ` [PATCH 2/6] lib: add closure parameter to compact status update callback Jani Nikula
2013-11-01 23:15 ` [PATCH] lib: update documentation of callback functions for database_compact and database_upgrade david
2013-11-01 23:19 ` Jani Nikula
2013-11-02 12:16 ` David Bremner
2013-11-01 14:27 ` [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it Jani Nikula
2013-11-02 12:14 ` David Bremner [this message]
2013-11-02 12:22 ` Jani Nikula
2013-11-01 14:27 ` [PATCH 4/6] cli: return error status if compaction fails Jani Nikula
2013-11-01 14:27 ` [PATCH 5/6] cli: add compact --backup=FILE option, don't backup by default Jani Nikula
2013-11-01 14:27 ` [PATCH 6/6] cli: add compact --verbose option and silence output without it Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li17rof6.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).