From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2528C431FC0
	for <notmuch@notmuchmail.org>; Sat, 10 May 2014 02:51:07 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NIjIA6qBd9bz for <notmuch@notmuchmail.org>;
	Sat, 10 May 2014 02:51:00 -0700 (PDT)
Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
	[87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 12C0E431FBF
	for <notmuch@notmuchmail.org>; Sat, 10 May 2014 02:51:00 -0700 (PDT)
Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
	4.72) (envelope-from <david@tethera.net>)
	id 1Wj3uZ-0006pT-6S; Sat, 10 May 2014 09:49:43 +0000
Received: (nullmailer pid 10909 invoked by uid 1000); Sat, 10 May 2014
	09:49:24 -0000
From: David Bremner <david@tethera.net>
To: Charles Celerier <cceleri@cs.stanford.edu>, Notmuch Mail
	<notmuch@notmuchmail.org>
Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.
In-Reply-To: <m2iopfoihw.fsf@jane.lan>
References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>
	<1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu>
	<1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>
	<87d2fov2qj.fsf@maritornes.cs.unb.ca> <m2zjisnwie.fsf@jane.lan>
	<87a9arvs9b.fsf@maritornes.cs.unb.ca> <m2iopfoihw.fsf@jane.lan>
User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 10 May 2014 18:49:24 +0900
Message-ID: <87lhua3qvv.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 10 May 2014 09:51:07 -0000

Charles Celerier <cceleri@cs.stanford.edu> writes:

> David Bremner <david@tethera.net> writes:
>
>     $ nm --version
>     GNU nm (GNU Binutils) 2.24
>     Copyright 2013 Free Software Foundation, Inc.
>     This program is free software; you may redistribute it under the terms of
>     the GNU General Public License version 3 or (at your option) any later version.
>     This program has absolutely no warranty.
>
> I'm not convinced the insertion of an underscore is nm's doing.

OIC. right, nm is not the issue.

> At this point, I'm not sure how to create a better version of this
> patch. Are we renaming functions in notmuch-private.h? Should we stick
> with objdump or switch to using nm?

I'd go with renaming any functions that start with notmuch to start with
_notmuch.

Since it seems neither nm nor objdump provides uniform output between
OS/X and Linux, there isn't an obvious advantage to switching to nm. Any
idea if objdump can be made to work (in this test) on OS/X ?

d