From: David Bremner <david@tethera.net>
To: patricktotzke@gmail.com
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] use notmuch_database_open_verbose
Date: Sun, 13 Mar 2016 09:37:40 -0300 [thread overview]
Message-ID: <87lh5m5zaj.fsf@zancas.localnet> (raw)
In-Reply-To: <CAM7JpKmVzZYZ8bpjc5qzWvBedKx4GT-y+EKWS1KQgZJ_LamKNw@mail.gmail.com>
Patrick Totzke <patricktotzke@gmail.com> writes:
> As far as I understand the bindings, the returned message is not needed
> because the return
> value of `Database._open` (line 212) contains information about the type of
> error that occurred.
> This is passed on two lines below if the open-call was unsuccessful.
>
> The docstrings for this method are not ideal (the mentioned "status"
> parameter is actually called "mode") but in terms of functionality it seems
> ok.
The error_message parameter (potentially) contains additional
information about an error. In any case, you're passing one too few
arguments to n_d_open_verbose, which doesn't seem like a good idea.
d
prev parent reply other threads:[~2016-03-13 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 15:17 [PATCH] use notmuch_database_open_verbose Patrick Totzke
2016-03-12 16:26 ` David Bremner
2016-03-12 16:33 ` David Bremner
2016-03-13 12:03 ` Patrick Totzke
[not found] ` <CAM7JpKmVzZYZ8bpjc5qzWvBedKx4GT-y+EKWS1KQgZJ_LamKNw@mail.gmail.com>
2016-03-13 12:37 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh5m5zaj.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=patricktotzke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).