From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: v3 of message properties patches
Date: Wed, 21 Sep 2016 09:01:33 -0300 [thread overview]
Message-ID: <87lgylea1u.fsf@zancas.localnet> (raw)
In-Reply-To: <87a8f2utfb.fsf@alice.fifthhorseman.net>
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> I've been running this series of patches since shortly after they were
> released. They work for me, and they're a critical feature to enable
> the cleartext index series i've been trying to land.
OK, that's certainly more testing and API evaluation than most series
get. I'd still like someone other than me to sanity check the code
itself, and the design decisions that hard to change later, namely
changes to the database format and the dump-restore format. And of
course the main reason we want code review is for to find the issues
that I am not aware of. Tomi, I know you've read the code at some level,
are you happy with merging the series?
>
> As i've been maintaining them against the master branch, they've
> diverged slightly from the series here. I'd be happy to send the
> updated revisions here if folks want them, but there are no substantive
> changes.
I can confirm that's just a rebase against master of what I have.
next prev parent reply other threads:[~2016-09-21 12:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 13:52 v3 of message properties patches David Bremner
2016-08-06 13:52 ` [PATCH 1/9] lib: read "property" terms from messages David Bremner
2016-08-06 13:52 ` [PATCH 2/9] lib: private string map (associative array) API David Bremner
2016-08-06 13:52 ` [PATCH 3/9] lib: basic message-property API David Bremner
2016-08-06 13:52 ` [PATCH 4/9] lib: extend private string map API with iterators David Bremner
2016-08-06 13:52 ` [PATCH 5/9] lib: iterator API for message properties David Bremner
2016-08-06 13:52 ` [PATCH 6/9] CLI: refactor dumping of tags David Bremner
2016-08-06 13:52 ` [PATCH 7/9] CLI: add properties to dump output David Bremner
2016-08-06 13:52 ` [PATCH 8/9] cli: optionally restore message properties from dump file David Bremner
2016-08-06 13:52 ` [PATCH 9/9] add has: query prefix to search for specific properties David Bremner
2016-08-06 14:18 ` David Bremner
2016-08-13 9:38 ` Jani Nikula
2016-08-13 11:31 ` David Bremner
2016-08-18 8:14 ` [PATCH] lib: reword comment about XFOLDER: prefix David Bremner
2016-08-18 8:18 ` David Bremner
2016-08-19 12:18 ` David Bremner
2016-08-13 19:00 ` [PATCH 9/9] add has: query prefix to search for specific properties Jameson Graef Rollins
2016-08-13 23:14 ` David Bremner
2016-09-20 21:56 ` v3 of message properties patches Daniel Kahn Gillmor
2016-09-21 12:01 ` David Bremner [this message]
2016-09-21 13:04 ` Tomi Ollila
2016-09-21 21:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgylea1u.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).