From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5BE106DE0962 for ; Sat, 31 Dec 2016 03:03:47 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.006 X-Spam-Level: X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IQcBDIeqqhdP for ; Sat, 31 Dec 2016 03:03:45 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 67DA36DE02AC for ; Sat, 31 Dec 2016 03:03:45 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cNHRT-0003iI-CM; Sat, 31 Dec 2016 06:03:15 -0500 Received: (nullmailer pid 8243 invoked by uid 1000); Sat, 31 Dec 2016 11:03:39 -0000 From: David Bremner To: mp39590@gmail.com, notmuch@notmuchmail.org Subject: Re: [PATCH] tests: add compatibility layer In-Reply-To: <20161222093120.41803-1-mp39590@gmail.com> References: <87tw9y2q8i.fsf@rocinante.cs.unb.ca> <20161222093120.41803-1-mp39590@gmail.com> Date: Sat, 31 Dec 2016 06:03:39 -0500 Message-ID: <87lguwfjhw.fsf@rocinante.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2016 11:03:47 -0000 mp39590@gmail.com writes: > From: Mikhail > > Make test-lib-common.sh load test-lib-<$PLATFORM>.sh to create > additional shim for platform specifics. > > Use test-lib-FREEBSD.sh to call GNU utilities instead of native ones. We had quite a bit of discussion of this on IRC. My (subjective) summary is that - we are generally fine with test-lib-${PLATFORM}.sh - we prefer functions to aliases (fixed in the latest version) - some people are uncomfortable with mandating gnu coreutils to run the tests on FreeBSD With respect to the last point, I agree it's not ideal, but it is better than not running them at all. We can incrementally remove the dependence on coreutils later if someone is motivated. This solution has the advantage of being easy, and not imposing a burden on people not using that platform. The only thing that still bugs me about this is the variable BSD_GDB. I'm a bit surprised that the same approach used for coreutils (i.e. rely on PATH) does not work. I guess because the names are the same it's less reliable for gdb. If we do a seperate variable, I'd prefer to use NOTMUCH_GDB (in line with NOTMUCH_PYTHON) since BSD_GDB suggests the native one. This could (eventually) be computed by configure, but this need not block this patch. Happy New-Year-In-Some-Timezones, David