From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 696E66DE0115
 for <notmuch@notmuchmail.org>; Sat, 10 Jun 2017 17:15:20 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.001
X-Spam-Level: 
X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[AWL=0.010, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id dktKverWSJM6 for <notmuch@notmuchmail.org>;
 Sat, 10 Jun 2017 17:15:20 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id C90866DE00B8
 for <notmuch@notmuchmail.org>; Sat, 10 Jun 2017 17:15:19 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1dJqUI-0000x1-Uw; Sat, 10 Jun 2017 20:12:14 -0400
Received: (nullmailer pid 3010 invoked by uid 1000);
 Sun, 11 Jun 2017 00:15:17 -0000
From: David Bremner <david@tethera.net>
To: Ioan-Adrian Ratiu <adi@adirat.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 05/11] emacs: notmuch-search: add filesize sorting
In-Reply-To: <20170518222708.30032-6-adi@adirat.com>
References: <20170518222708.30032-1-adi@adirat.com>
 <20170518222708.30032-6-adi@adirat.com>
Date: Sat, 10 Jun 2017 21:15:17 -0300
Message-ID: <87lgozcrca.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jun 2017 00:15:20 -0000

Ioan-Adrian Ratiu <adi@adirat.com> writes:

> Besides the previous date-based result orderings (oldest-first and
> newest-first) add two more filesize-based orderings: biggest-first
> smallest-first.
>
> The orderings are interchangeable, you can specify any one as the
> default via notmuch-search-default-sort-order or as the preffered
                                                    spelling ^
> ordering for a saved search (via the :sort-order property).
>
> Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
> ---
>  emacs/notmuch-hello.el |  9 ++++++---
>  emacs/notmuch-lib.el   |  4 +++-
>  emacs/notmuch.el       | 12 ++++++++++--
>  3 files changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 3ba2a16b..51117577 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -95,7 +95,9 @@ searches so they still work in customize."
>  			    (choice :tag " Sort Order"
>  				    (const :tag "Default" nil)
>  				    (const :tag "Oldest-first" oldest-first)
> -				    (const :tag "Newest-first" newest-first)))
> +				    (const :tag "Newest-first" newest-first)
> +				    (const :tag "Biggest-first" biggest-first)
> +				    (const :tag "Smallest-first" smallest-first)))

I agree with Tomi that Largest sounds better than Biggest here.