From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sebastian.poeplau@eurecom.fr>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 2D7F96DE0361
 for <notmuch@notmuchmail.org>; Tue, 31 Jul 2018 02:49:51 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.006
X-Spam-Level: 
X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id pZxcAc-qz2e0 for <notmuch@notmuchmail.org>;
 Tue, 31 Jul 2018 02:49:42 -0700 (PDT)
Received: from smtp.eurecom.fr (smtp.eurecom.fr [193.55.113.210])
 by arlo.cworth.org (Postfix) with ESMTP id E5B8C6DE0355
 for <notmuch@notmuchmail.org>; Tue, 31 Jul 2018 02:49:36 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="5.51,426,1526335200"; 
   d="scan'208";a="7984047"
Received: from waha.eurecom.fr (HELO smtps.eurecom.fr) ([10.3.2.236])
 by drago1i.eurecom.fr with ESMTP; 31 Jul 2018 11:49:33 +0200
Received: from archibald (unknown [193.55.114.4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by smtps.eurecom.fr (Postfix) with ESMTPSA id 7E801AE5;
 Tue, 31 Jul 2018 11:49:32 +0200 (CEST)
From: Sebastian Poeplau <sebastian.poeplau@eurecom.fr>
To: David Bremner <david@tethera.net>,
 Jeffrey Stedfast <jestedfa@microsoft.com>,
 "notmuch\@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: Handling mislabeled emails encoded with Windows-1252
In-Reply-To: <87k1pbg4eg.fsf@tethera.net>
References: <87lgaeat37.fsf@eurecom.fr> <8736w91jz0.fsf@tethera.net>
 <DA63786E-755F-4ABA-84A0-B420BAEAA4CE@microsoft.com>
 <87effszpg7.fsf@eurecom.fr> <87zhyby589.fsf@eurecom.fr>
 <9C0F603A-6125-4CF0-8AE7-E02301355906@microsoft.com>
 <87wotdxjuu.fsf@eurecom.fr> <87tvohxiz8.fsf@eurecom.fr>
 <87k1pbg4eg.fsf@tethera.net>
Date: Tue, 31 Jul 2018 11:49:31 +0200
Message-ID: <87lg9rybtg.fsf@eurecom.fr>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 09:49:51 -0000

Hi David,

Thanks for the hints! I'll prepare a test and the patch based on master
shortly.

Cheers,
Sebastian


David Bremner <david@tethera.net> writes:

> Sebastian Poeplau <sebastian.poeplau@eurecom.fr> writes:
>
>>> Nice, I'll add it.
>>
>> Updated patch attached.
>>
>> Cheers,
>> Sebastian
>
> Thanks to both of you for working on this. The code looks ok to me, I
> have only some procedural comments.
>
> In order to merge it I'll need at least one test. I think
> test/T300-encoding.sh is probably the right place. There are a few
> different styles of test; you can either put things in variables as in
> that file, or use the more dominant
>
> test_subtest_begin_test "description"
> cat << EOF > EXPECTED
> this is my expected output
> EOF
> notmuch show STUFF > OUTPUT
> test_expect_equal_file EXPECTED OUTPUT
>
> Feel free to bug the list for help on making tests (or #notmuch on
> freenode).
>
> Please also use git-send-email to send your patch(es), with commit
> messages with an eye to
>
>          https://notmuchmail.org/contributing/#index5h2
>
> To minimize the chance of problems, it's probably best to base your
> commits on master, although the patch you sent applied fine here.
>
> Thanks,
>
> David