From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 710046DE022F for ; Mon, 27 Aug 2018 07:33:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.71 X-Spam-Level: X-Spam-Status: No, score=-0.71 tagged_above=-999 required=5 tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eD1oV3KHZA6g for ; Mon, 27 Aug 2018 07:33:14 -0700 (PDT) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by arlo.cworth.org (Postfix) with ESMTPS id DBF576DE021C for ; Mon, 27 Aug 2018 07:33:13 -0700 (PDT) Received: from len.workgroup ([185.46.137.17]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Ma2Lr-1gDsra0R3f-00LjCX for ; Mon, 27 Aug 2018 16:33:09 +0200 From: Gregor Zattler To: notmuch@notmuchmail.org Subject: Re: [PATCH] WIP: sort top level messages in thread In-Reply-To: <20180827015353.23652-1-david@tethera.net> References: <87va8unnor.fsf@len.workgroup> <20180827015353.23652-1-david@tethera.net> Mail-Followup-To: notmuch@notmuchmail.org Date: Mon, 27 Aug 2018 15:44:07 +0200 Message-ID: <87lg8r9b6g.fsf@len.workgroup> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:xymxXzMP/RpYqllHcYb849biKXItODHw4lGez9BATAtAs7Kv/e6 gPOqKcHNKet9J99vmKFFWQI4u89XkmJfeyYreCbHPHxrce/AtTDuf83m1b8DG0HFR/dT3k4 eAJTqf3q3sT3KYAQp8PRLZ/eW4wWqhXbcT9Lq2c5MuusTXJTGsMWKHwc9fCDBM6jRV9BjD5 pFlEYotn5X18uIKGFRWYw== X-UI-Out-Filterresults: notjunk:1;V01:K0:cjM17FOwOZc=:qF/4TJeNuY5Lowf4DMuSbO i+vndO1Goa8QKDgZNuF2X1ZrG9+h3fDBv6lTViqGfIL97OcH/pDK+r0kxuFxt1X45pj4TZxVA UnCBpbP4ypx+FayZi4CDmTcoLdVwIatV81WLznnv0i1oBtVSNXcvJPh111WrtRyfQ1VEfWgzL ZVYgpe9BIeDHk20O/WdrDZp66L0HJMsjcbMpfU5qal1hS0ElCpqED39y4P+xKJvjCTfm/t/Cl z5nM7H13vX0LBBOzUqEGFyHimXWUtiK/GxnkwPE/ExfM3OVmkAw8Xe+OZnKwPg5HwQzf0oNfT caT996C+yiJk6UUVe3oSvksiRS1HeBQB0nDwM3rnBzPWNqn2YwhCovGXP9P5/1NSoZIjzj+kJ I1+QfrbspnR/ucGiOV3nKlYcFZM2BBjFk/KTO1P1VJgpzRfp0WeGAFIbt0PEhUqpCI/C7nGyJ ZPTXyut77n6XsW45QS8m2LCrI5EfevAtPEHk/3EEtIyYQz23s1pA+k4zL3VBmSlFAjlqA8iYs 9Ak3qdOA+tjiU+eHQGrSAqjW/RiS/6+CUdMKoKDsn979rk/VugUtTFQKSLfvReCzCrRSu6XSX wfdJqe3Kmdua5EW4pF+zwvDfwCwuedm9kS83E12r3X1rPNgwd/9y7WUOh80vEOajBGzs9W1kP +Ma1QEJe+BWombMiLyY81JSmJFQMmHn73Zz5SHrLVxZAy4v4Ex0FzJ0Vf8vD70bNYF5X2Ul2I z28FvvXHDjEo31OGcYyLrEJC3MTTgAY3h8Q+CogifRO1LK3BQKqeR9whMXSSSSKO2cE7ZTz4E tQt6iw0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 14:33:15 -0000 Hi David, * David Bremner [2018-08-26; 22:53]: > this needs a test, and memory de-allocation of the replaced > lists. Currently it creates a fair amount of garbage. > --- > Sorry for the lack of reply, some vacation intervened. Thanks, hope it was relaxing. > Can you test > this patch? I think it fixes the second thread also. The patch applied cleanly on top of the others (which I use regularly with no problems) and fixed the threading order problem in the two test cases I send you. Other RT-emails are also ordered nicely now. Thanks for this patch, I'll also use it regularly. Gregor