* notmuch-message-mark-replied
@ 2019-06-01 0:20 David Bremner
2019-06-03 9:18 ` notmuch-message-mark-replied Örjan Ekeberg
0 siblings, 1 reply; 7+ messages in thread
From: David Bremner @ 2019-06-01 0:20 UTC (permalink / raw)
To: notmuch
In d9800c8 we deleted the function notmuch-message-mark-replied.
Should we make a deprecated-alias for
notmuch-message-apply-queued-tag-changes?
d
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: notmuch-message-mark-replied
2019-06-01 0:20 notmuch-message-mark-replied David Bremner
@ 2019-06-03 9:18 ` Örjan Ekeberg
2019-06-03 10:30 ` notmuch-message-mark-replied David Bremner
0 siblings, 1 reply; 7+ messages in thread
From: Örjan Ekeberg @ 2019-06-03 9:18 UTC (permalink / raw)
To: David Bremner, notmuch
David Bremner <david@tethera.net> writes:
> In d9800c8 we deleted the function notmuch-message-mark-replied.
>
> Should we make a deprecated-alias for
> notmuch-message-apply-queued-tag-changes?
The two functions are not interchangeable, so it may not be appropriate
to mark it as an alias.
notmuch-message-mark-replied looked for a In-Reply-To: header while
notmuch-message-apply-queued-tag-changes checks if the message has
notmuch-message-queued-tag-changes set (it is set when composing a reply).
On the other hand; if a user has code which explicitly sets the
message-send-hook, the new function will serve as the natural
replacement for the deleted one.
/Örjan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: notmuch-message-mark-replied
2019-06-03 9:18 ` notmuch-message-mark-replied Örjan Ekeberg
@ 2019-06-03 10:30 ` David Bremner
2019-06-03 15:16 ` notmuch-message-mark-replied Rollins, Jameson
0 siblings, 1 reply; 7+ messages in thread
From: David Bremner @ 2019-06-03 10:30 UTC (permalink / raw)
To: Örjan Ekeberg, notmuch
Örjan Ekeberg <ekeberg@kth.se> writes:
> David Bremner <david@tethera.net> writes:
>> In d9800c8 we deleted the function notmuch-message-mark-replied.
>>
>> Should we make a deprecated-alias for
>> notmuch-message-apply-queued-tag-changes?
>
> The two functions are not interchangeable, so it may not be appropriate
> to mark it as an alias.
[snip]
> On the other hand; if a user has code which explicitly sets the
> message-send-hook, the new function will serve as the natural
> replacement for the deleted one.
So maybe just a NEWS snippet to point those users in the right
direction?
d
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: notmuch-message-mark-replied
2019-06-03 10:30 ` notmuch-message-mark-replied David Bremner
@ 2019-06-03 15:16 ` Rollins, Jameson
2019-06-03 15:21 ` notmuch-message-mark-replied David Bremner
2019-06-03 15:32 ` notmuch-message-mark-replied Örjan Ekeberg
0 siblings, 2 replies; 7+ messages in thread
From: Rollins, Jameson @ 2019-06-03 15:16 UTC (permalink / raw)
To: David Bremner, Örjan Ekeberg, notmuch@notmuchmail.org
On Mon, Jun 03 2019, David Bremner <david@tethera.net> wrote:
> Örjan Ekeberg <ekeberg@kth.se> writes:
>
>> David Bremner <david@tethera.net> writes:
>>> In d9800c8 we deleted the function notmuch-message-mark-replied.
>>>
>>> Should we make a deprecated-alias for
>>> notmuch-message-apply-queued-tag-changes?
>>
>> The two functions are not interchangeable, so it may not be appropriate
>> to mark it as an alias.
> [snip]
>> On the other hand; if a user has code which explicitly sets the
>> message-send-hook, the new function will serve as the natural
>> replacement for the deleted one.
>
> So maybe just a NEWS snippet to point those users in the right
> direction?
I have the following in my emacs config:
'(message-send-hook
(quote
(notmuch-message-mark-replied notmuch-fcc-header-setup)))
I'm wondering what if anything I should replace this with.
jamie.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: notmuch-message-mark-replied
2019-06-03 15:16 ` notmuch-message-mark-replied Rollins, Jameson
@ 2019-06-03 15:21 ` David Bremner
2019-06-03 15:32 ` notmuch-message-mark-replied Örjan Ekeberg
1 sibling, 0 replies; 7+ messages in thread
From: David Bremner @ 2019-06-03 15:21 UTC (permalink / raw)
To: Rollins, Jameson, Örjan Ekeberg, notmuch@notmuchmail.org
"Rollins, Jameson" <jrollins@caltech.edu> writes:
> I have the following in my emacs config:
>
> '(message-send-hook
> (quote
> (notmuch-message-mark-replied notmuch-fcc-header-setup)))
As far as I know it can be deleted. At least both marking as replied and
fcc headers work OK for me without it.
d
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: notmuch-message-mark-replied
2019-06-03 15:16 ` notmuch-message-mark-replied Rollins, Jameson
2019-06-03 15:21 ` notmuch-message-mark-replied David Bremner
@ 2019-06-03 15:32 ` Örjan Ekeberg
2019-06-03 15:53 ` notmuch-message-mark-replied Rollins, Jameson
1 sibling, 1 reply; 7+ messages in thread
From: Örjan Ekeberg @ 2019-06-03 15:32 UTC (permalink / raw)
To: Rollins, Jameson, notmuch@notmuchmail.org
"Rollins, Jameson" <jrollins@caltech.edu> writes:
> I have the following in my emacs config:
>
> '(message-send-hook
> (quote
> (notmuch-message-mark-replied notmuch-fcc-header-setup)))
>
> I'm wondering what if anything I should replace this with.
You should probably remove this altogether.
notmuch-message-mark-replied used to be the default value for this hook,
but has now been replaced by notmuch-message-apply-queued-tag-changes.
notmuch-fcc-header-setup is called already when composing a message, so
it no longer is needed to call is from the hook.
/Örjan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: notmuch-message-mark-replied
2019-06-03 15:32 ` notmuch-message-mark-replied Örjan Ekeberg
@ 2019-06-03 15:53 ` Rollins, Jameson
0 siblings, 0 replies; 7+ messages in thread
From: Rollins, Jameson @ 2019-06-03 15:53 UTC (permalink / raw)
To: Örjan Ekeberg, notmuch@notmuchmail.org
On Mon, Jun 03 2019, Örjan Ekeberg <ekeberg@kth.se> wrote:
> "Rollins, Jameson" <jrollins@caltech.edu> writes:
>> I have the following in my emacs config:
>>
>> '(message-send-hook
>> (quote
>> (notmuch-message-mark-replied notmuch-fcc-header-setup)))
>>
>> I'm wondering what if anything I should replace this with.
>
> You should probably remove this altogether.
>
> notmuch-message-mark-replied used to be the default value for this hook,
> but has now been replaced by notmuch-message-apply-queued-tag-changes.
>
> notmuch-fcc-header-setup is called already when composing a message, so
> it no longer is needed to call is from the hook.
Great thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-03 15:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-01 0:20 notmuch-message-mark-replied David Bremner
2019-06-03 9:18 ` notmuch-message-mark-replied Örjan Ekeberg
2019-06-03 10:30 ` notmuch-message-mark-replied David Bremner
2019-06-03 15:16 ` notmuch-message-mark-replied Rollins, Jameson
2019-06-03 15:21 ` notmuch-message-mark-replied David Bremner
2019-06-03 15:32 ` notmuch-message-mark-replied Örjan Ekeberg
2019-06-03 15:53 ` notmuch-message-mark-replied Rollins, Jameson
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).