From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QJ+dBYmbsF4RVQAA0tVLHw (envelope-from ) for ; Mon, 04 May 2020 22:47:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 9ZkbG5ObsF5vEwAA1q6Kng (envelope-from ) for ; Mon, 04 May 2020 22:47:47 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3A3D94451F for ; Mon, 4 May 2020 22:47:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 57A0B6DE10B2; Mon, 4 May 2020 15:47:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7f0BdU12r2Jy; Mon, 4 May 2020 15:47:39 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 597DD6DE102E; Mon, 4 May 2020 15:47:39 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6C3936DE102E for ; Mon, 4 May 2020 15:47:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H6UxF0DWD5FK for ; Mon, 4 May 2020 15:47:35 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id C509B6DE0F07 for ; Mon, 4 May 2020 15:47:35 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.92) (envelope-from ) id 1jVjs1-000248-1V; Mon, 04 May 2020 18:47:29 -0400 Received: (nullmailer pid 1765566 invoked by uid 1000); Mon, 04 May 2020 22:47:28 -0000 From: David Bremner To: Tomi Ollila , Franz Fellner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: known broken test for reindex tag preservation In-Reply-To: References: <87h7wvg6oq.fsf@tethera.net> <20200504140024.1617656-1-david@tethera.net> Date: Mon, 04 May 2020 19:47:28 -0300 Message-ID: <87lfm7e2rj.fsf@tethera.net> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [-1.01 / 13.00]; GENERIC_REPUTATION(0.00)[-0.46611567307799]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:c]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.00), ip: 50.126.95.6(-0.47)]; DWL_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; MX_GOOD(-0.50)[notmuchmail.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[iki.fi,gmail.com,notmuchmail.org]; RCVD_IN_DNSWL_FAIL(0.00)[50.126.95.6:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[david@tethera.net,notmuch-bounces@notmuchmail.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[notmuchmail.org:email,iki.fi:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; DMARC_NA(0.00)[tethera.net]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: hs4P87zAavfc Tomi Ollila writes: > On Mon, May 04 2020, David Bremner wrote: > >> In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags >> starting with 'attachment' are removed by 'notmuch reindex'. This is >> probably related to the use of STRNCMP_LITERAL in > > Haa, I looked this briefly but failed to see it is STRNCMP_LITERAL, > not STRCMP_LITERAL (the latter could be optimized strcmp using memcmp > w/ constant len) > > Series LGTM (I'm trying to look away that 'we' passive ;) We have pushed. d