From: David Bremner <david@tethera.net>
To: Gregor Zattler <telegraph@gmx.net>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] lib/n_d_index_file: check return value from _n_m_add_filename
Date: Sun, 18 Apr 2021 10:05:09 -0300 [thread overview]
Message-ID: <87lf9fbv5m.fsf@tethera.net> (raw)
In-Reply-To: <20210320131052.2254248-1-david@tethera.net>
David Bremner <david@tethera.net> writes:
> Ignoring this return value seems like a bad idea in general, and in
> particular it has been hiding one or more bugs related to handling
> long directory names.
> ---
>
> This is not a fix for the aforementioned bugs, but it at least makes
> clear part of the problem. The XDDIRENTRYnnnnn: terms are not checked
> for length in the same way as XDIRECTORY terms. It isn't clear the
> same hashing strategy will work, as the XDDIRECTORY terms are used to
> create lists of child directories. It may be the best we can do is
> enforce a limit on the length of path elements in trees indexed by
> notmuch.
Applied to master.
d
next prev parent reply other threads:[~2021-04-18 13:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 13:19 consistent database corruption with notmuch new Gregor Zattler
2020-12-13 14:12 ` David Bremner
2020-12-13 14:15 ` Gregor Zattler
2020-12-13 15:13 ` Gregor Zattler
2020-12-13 18:10 ` David Bremner
2020-12-13 18:12 ` David Bremner
2020-12-14 19:19 ` David Bremner
2020-12-13 21:22 ` Gregor Zattler
2020-12-14 19:22 ` Gregor Zattler
2021-01-30 8:54 ` out of memory on idle machine (was: Re: consistent database corruption with notmuch new) Gregor Zattler
2021-01-30 12:58 ` David Bremner
2021-01-31 8:16 ` out of memory on idle machine Gregor Zattler
2021-01-31 20:21 ` Gregor Zattler
2021-02-03 11:32 ` David Bremner
2021-02-03 11:59 ` David Bremner
2021-02-07 21:46 ` Gregor Zattler
2021-02-11 10:53 ` David Bremner
2021-02-11 11:32 ` David Bremner
2021-03-17 19:47 ` bug: chokes on long directory names (was: Re: out of memory on idle machine) Gregor Zattler
2021-03-18 1:25 ` [PATCH] test: add known broken test for long directory bug David Bremner
2021-03-18 7:26 ` Tomi Ollila
2021-03-18 11:02 ` David Bremner
2021-03-20 13:10 ` [PATCH] lib/n_d_index_file: check return value from _n_m_add_filename David Bremner
2021-04-18 13:05 ` David Bremner [this message]
2021-03-18 1:39 ` bug: chokes on long directory names (was: Re: out of memory on idle machine) David Bremner
2021-02-12 4:19 ` out of memory on idle machine Olly Betts
2021-02-21 9:42 ` Gregor Zattler
2021-02-09 4:34 ` Olly Betts
2021-02-13 20:30 ` Gregor Zattler
2020-12-14 9:11 ` consistent database corruption with notmuch new David Edmondson
2020-12-14 12:27 ` Gregor Zattler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf9fbv5m.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=telegraph@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).