From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gCavIpWLjmABwAAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 13:23:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IGxBHpWLjmD0VAAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 11:23:01 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56EB42CB8C for ; Sun, 2 May 2021 13:22:57 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 136E3271D4; Sun, 2 May 2021 07:22:54 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8D8AF271D0 for ; Sun, 2 May 2021 07:22:51 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 69B6960016; Sun, 2 May 2021 07:22:51 -0400 (EDT) Received: (nullmailer pid 977948 invoked by uid 1000); Sun, 02 May 2021 11:22:50 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 0/9] test: ruby: several cleanups and simplifications In-Reply-To: <20210501115923.483816-1-felipe.contreras@gmail.com> References: <20210501115923.483816-1-felipe.contreras@gmail.com> Date: Sun, 02 May 2021 08:22:50 -0300 Message-ID: <87lf8xmlbp.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: EB7477TEEW3G4XNWKADXJ54WNC7JIJQH X-Message-ID-Hash: EB7477TEEW3G4XNWKADXJ54WNC7JIJQH X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor , Ludovic LANGE , Tomi Ollila , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619954577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NbORBvm6kntHq65LitYLqq49MhNqH/k7Hb5YqE3zlJU=; b=ntl+jnNvEHw9hZcVa3YLFQfXs1FC/pxUvs4PAkN4qvCoCht05UH/i6l7FeMrnfJt66b1DP ZfE99LVKdCEHcq7hwWn76977E9bJT6xMjsvbyrK2fRhLZQxfh7lkz3xF7/V2A0kgkj6VlT jwUZ/Er4qXkRjk0T6DSnFCGwB2qhUB++j1LEmAZJw5HYHW8debfrJBpzFjMUE7qHIT5M17 cffGu0lWDXDTLyUcqKUo/PCx4H0f/xdxz3Wlsjv6cAXsU/Ze0KtOK8gAkQ990casKCmYGK mEBAyFUo28A0ZLxBp3Mjgr2qchztT1Hqxou9YQBH+WKZQxXiKRupKuif8I6TLA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619954577; a=rsa-sha256; cv=none; b=Rrsskws91upc4Bn6w/fQtfkt7IKWdKUod0erqHFZjb8InRoK3XI2Qls68jdx/UqdFHw3V5 SBhu8QvFnjXBPgD7lWJQJdFu9u5qNvOwpwcvPF4NXKEJ8DrchlXl25Wdls170eOHJCvN6b yfsVsy+Ge+FXkxHdtXqXYfq0KZV5GpL2M8aRu17ou1XBvIaL6WpV6N+QbqZOEIM0IipU18 /M9TaW0qaapWEfs3bGTDCjioduatFNi/7AlGKlXSw1Sm3yAHHxhTCzUsyM7rS6yT4tUsq4 ml/VxqqtucKjV02KFks6Tea0CPN08jLoDMp2+9Ds8cyic9LeMtI9NNc2rM6riQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.57 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 56EB42CB8C X-Spam-Score: -0.57 X-Migadu-Scanner: scn0.migadu.com X-TUID: s6bI08t3Md6G Felipe Contreras writes: > I found a lot of areas of improvement in the Ruby tests, so I decided to clean them up. > > With these changes the tests are now much simpler and follow more closely the typical Ruby idioms. > > Felipe Contreras (9): > test: move test_ruby() inside the only client > test: ruby: refactor test_ruby() > test: ruby: simplify MAIL_DIR check > test: ruby: simplify MAIL_DIR initialization > test: ruby: simplify test_ruby() > test: ruby: use much more standard puts I have applied the first 6 patches to master. d