From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH] ruby: improve compilation with CFLAGS
Date: Sat, 22 May 2021 09:24:46 -0300 [thread overview]
Message-ID: <87lf87t0q9.fsf@tethera.net> (raw)
In-Reply-To: <87a6otzl51.fsf@tethera.net>
David Bremner <david@tethera.net> writes:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> The ruby MakeMakefile generates a makefile that is suboptimal, which has
>> CFLAGS like this:
>>
>> CFLAGS = $(CCDLFLAGS) -march=x86-64 -mtune=generic \
>> -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG)
>
> Ruby 2.7 doesn't seem to add -fno-plt, so this would be a change for
> some people building the ruby bindings. The flag is available from gcc
> 6.x (2016). For clang I guess it is 2017ish. If anyone thinks this is
> too recent of a toolchain dependence, now is your chance to object.
Nobody complained, so I applied this to master.
d
prev parent reply other threads:[~2021-05-22 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 5:47 [PATCH] ruby: improve compilation with CFLAGS Felipe Contreras
2021-05-17 5:50 ` Felipe Contreras
2021-05-17 10:53 ` David Bremner
2021-05-22 12:24 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf87t0q9.fsf@tethera.net \
--to=david@tethera.net \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).