unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Eliza Velasquez <eliza@eliza.sh>, notmuch@notmuchmail.org
Subject: Re: [BUG] notmuch_message_tags_to_maildir_flags does not always invalidate filenames_list
Date: Tue, 24 May 2022 09:45:08 -0300	[thread overview]
Message-ID: <87leur85gr.fsf@tethera.net> (raw)
In-Reply-To: <877d6g1t7e.fsf@eliza.sh>

Eliza Velasquez <eliza@eliza.sh> writes:

> Hello notmuch,
>
> As the subject says, it seems like the filename cache for a message is
> not reliably invalidated when notmuch_message_tags_to_maildir_flags is
> called, causing the following series of function calls to behave
> unexpectedly.
>
> - notmuch_database_index_file
> - notmuch_message_get_filenames
> - notmuch_message_tags_to_maildir_flags
> - notmuch_message_get_filenames (stale list returned)
>
> According to the investigator [1], this happens about 10% of the time,
> but it's possible that this is just because there is some quirk in the
> client-side code causing it to trigger only sometimes.
>
> [1] https://github.com/elizagamedev/mujmap/pull/10#issuecomment-1131587169
>

I have been looking at this code, and making some small improvements [1],
but without a C reproducer I don't really know if it helps the
submitter's issue.

d

[1]: https://nmbug.notmuchmail.org/nmweb/show/20220523233901.3506880-1-david@tethera.net

  parent reply	other threads:[~2022-05-24 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  8:52 [BUG] notmuch_message_tags_to_maildir_flags does not always invalidate filenames_list Eliza Velasquez
2022-05-20 14:30 ` David Bremner
2022-05-24 12:45 ` David Bremner [this message]
2022-05-25  1:28   ` Eliza Velasquez
2022-06-01 12:02     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leur85gr.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=eliza@eliza.sh \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).