From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wAGMB8gw9mKIfwEAbAwnHQ (envelope-from ) for ; Fri, 12 Aug 2022 12:51:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QOh2Bsgw9mI2ngAAG6o9tA (envelope-from ) for ; Fri, 12 Aug 2022 12:51:52 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D6249420D1 for ; Fri, 12 Aug 2022 12:51:51 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AAF005F41A; Fri, 12 Aug 2022 10:51:49 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id CBC635F3E2 for ; Fri, 12 Aug 2022 10:51:46 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5B0915FBC0; Fri, 12 Aug 2022 06:51:46 -0400 (EDT) Received: (nullmailer pid 2874419 invoked by uid 1000); Fri, 12 Aug 2022 10:51:45 -0000 From: David Bremner To: Mohsin Kaleem , notmuch@notmuchmail.org Subject: Re: [PATCH 7/9] test: Fix Navigation of notmuch-hello to search results In-Reply-To: <20220807145733.129867-7-mohkale@kisara.moe> References: <87v8re66mg.fsf@tethera.net> <20220807145733.129867-1-mohkale@kisara.moe> <20220807145733.129867-7-mohkale@kisara.moe> Date: Fri, 12 Aug 2022 07:51:45 -0300 Message-ID: <87lertg2f2.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: SOR5X6JDNF3HA6LHJ7DVBFEH2V33FRWK X-Message-ID-Hash: SOR5X6JDNF3HA6LHJ7DVBFEH2V33FRWK X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Mohsin Kaleem X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660301511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=I5e/uPsyQBrsYJSDB/Of/3Zh/C6mXptY6Gn1k2ZQCbY=; b=Tv5wMrq4rN8UFboQ9JU8FrrmirBUJYQvOmikQMR5sb2uysCPZo7fDJXaxFQI2VIZA5xSLG dSQ59/KXh6JiF7QOJV7HL0yBAJ5ZCb/Cingdf5R48D5K/tC95LWG8HS6OpzWtd7u8JR0WS eSebp2vlfx0tuCaFG7LzPQYAix//CvWC46SkzzyPzRdfdsx3irpPzcq3khlmunI8jF5kiX bNbYHK8On9vYCPT45YH7mQQQYpnyu+mu/bep1LnuVnfbhrcBhyXkOGgny7uRnbX/0Glu3y i1FOiSqP0iymkY7KhkjLyjMtoG0Ek+noKe8dtesn46xE30vDzk7KEI2eSMM2lA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660301511; a=rsa-sha256; cv=none; b=UMzQZe2K8iLnDY/bmfnmz6rW67tmE9zHw73AAbph5GqKXPrFngIZTiaPrDLo6rbImO73nk qmkRjku1pKhzPPKu+1DDWr6lP1II1oWc5KVvDoVlDuzZjItQo5xWuRaipAGZXAZ3W32WGr QdvPbkxHBictEXf114wcRou2i9hrAi1AwYSGKf8oEDCFIAMI5Qa3WE9g5scGd8KfQcxe97 wBJmdRPBBqT9PdO0b03IwVRr7nK7kq/X2Wdvf8XERDSaKSBJvY3rYy0s5SgJMshVhcHsYp kq5nvcGNl9UxZuBJy6EUdVE7N2j6vfg0kVJSh5im4gh8dE2lJ9ubi8SnizU6qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.68 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D6249420D1 X-Spam-Score: -2.68 X-Migadu-Scanner: scn0.migadu.com X-TUID: U3viiyENS0eq Mohsin Kaleem writes: > The default value of oldest-first is true so the oldest mail is shown > first by default. This test case used the tree-from-search function > which now persists this value of true (previously always defaulting to > nil in its place) which produced a different tree output where the > oldest-mail is sorted first despite previously being sorted last. Fixed > by adding in this output as a separate file and comparing against it > instead. Please make sure the test suite passes after every commit. Probably that means squashing this fix into the previous commit. d