From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 53F67431FC3 for ; Mon, 1 Mar 2010 09:35:19 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.68 X-Spam-Level: X-Spam-Status: No, score=-2.68 tagged_above=-999 required=5 tests=[AWL=-1.570, BAYES_05=-1.11] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2Vd7u0CPln16 for ; Mon, 1 Mar 2010 09:35:18 -0800 (PST) Received: from tarap.cc.columbia.edu (tarap.cc.columbia.edu [128.59.29.7]) by olra.theworths.org (Postfix) with ESMTP id A478D431FBD for ; Mon, 1 Mar 2010 09:35:18 -0800 (PST) Received: from servo.finestructure.net (geco.phys.columbia.edu [128.59.170.159]) (user=jgr2110 author=jrollins@finestructure.net mech=PLAIN bits=0) by tarap.cc.columbia.edu (8.14.3/8.14.3) with ESMTP id o21HZ9FT018314 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Mon, 1 Mar 2010 12:35:09 -0500 (EST) Received: from jrollins by servo.finestructure.net with local (Exim 4.71) (envelope-from ) id 1Nm9WP-0005Gh-Ow; Mon, 01 Mar 2010 12:35:09 -0500 From: Jameson Rollins To: David Bremner , Sebastian Spaeth , notmuch@notmuchmail.org In-Reply-To: <878wacrm03.fsf@rocinante.cs.unb.ca> References: <87r5o49kow.fsf@SSpaeth.de> <1267457946-30347-1-git-send-email-Sebastian@SSpaeth.de> <878wacrm03.fsf@rocinante.cs.unb.ca> Date: Mon, 01 Mar 2010 12:35:06 -0500 Message-ID: <87k4twc5dh.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-No-Spam-Score: Local X-Scanned-By: MIMEDefang 2.68 on 128.59.29.7 Subject: Re: [PATCH] notmuch-show: add tags to json output X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2010 17:35:19 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 01 Mar 2010 13:26:52 -0400, David Bremner wrote: > On Mon, 1 Mar 2010 16:39:06 +0100, Sebastian Spaeth wrote: > > The previous json patches forgot to add the notmuch tags to the json > > output. This is inconsistent to the text output so here they are. We > > just output a 'tags' field that sends a space delimited list of > > json-encoded notmuch tags. > >=20 > > Signed-off-by: Sebastian Spaeth >=20 > I agree we need tags in json output, but I think that making the client > parse the string of (space delimited?) tags defeats a bit the purpose of > having json output. What do you think about=20 >=20 > "tags": [ "inbox", "unread" ]=20 >=20 > instead of=20 >=20 > "tags": "inbox unread" I agree that having the JSON "tags" output field be an array of strings makes the most sense. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJLi/rKAAoJEO00zqvie6q8zLsP/AvomIytsO5SBTqfA2BQIIdQ /FdtnDBR/sr2kn2hhtb17YKi2SzH3qKokWRDKeiGgWvB4wRFBYo271xSfRHoHze4 6lFHTMlMx9iFkwDbKzAF1K18wuh80UjMA6J0U9pIXVW5YV9UCYsqDS/Vsg5rsHfX NqUoEuqPEnHmAcvA6eJPQiBajAyyHitwWB6TJMtlYId/zJMkQn2yDmGG4SUbEWy4 DBJwx/rOLu8COtR5DoOUyStFyzw7rpoYIQTiABPn2Mw1aVZ9q88ssnq2u/vOpK7i OKt4K4n6+OyUXcQ/QxerZRSKNgUtjzTbUiOuqWijtIcMJ6amR5AQkYIm7+FqDGS5 z8kkr6ljALYLhR2sbNDvCuGz/EUPMRuJ5XuCQkKmkmb+Mfu0s5hyQjYC7JqiSU2T gJ96AGY2yZQOpEsjtfdijp/Oy56EKmPdL1MGCA/zLJ/pZPJ0lFCEbWY8UXjqUWAR cCaZdAG2H5VKox9XfmmDvMdM8W1yqrLJ1MZggt2aaZo3fsqfIAYToqFLNIS+8of+ WFZD8veyxDGQeqNPMPHsJVxBJthIEEEoITIURsD90QwZZ92sjnQHx+tt8eRTBAbQ axfJwI7FmCrwxeO82GjynE3v6Acu/gcn2e5aoTbS03SoPUb1GfVtT6nX/xabodw3 8vPbWPMmPQwNudRCpeE9 =IS6F -----END PGP SIGNATURE----- --=-=-=--