From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Anton Khirnov <anton@khirnov.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] python/thread: always return a string in get_subject/authors
Date: Mon, 09 May 2011 11:23:16 -0400 [thread overview]
Message-ID: <87k4dzc2zf.fsf@gogo.home> (raw)
In-Reply-To: <20110509151310.4FF447F508@zohar.localdomain>
On Mon, 09 May 2011 17:13:10 +0200, Anton Khirnov <anton@khirnov.net> wrote:
> But those aren't message headers, those are thread properties. And I'd
> argue that a thread always has authors and a subject (possibly empty).
The RFC says yes on the author, no on the subject. The only things
guaranteed are "From:" and originating timestamp. So I'm not sure why
subject should be guaranteed a string result and not, say, "Cc."
My sense is that Python users are prety good with testing against None,
especially since (not "") == (not []) == (not None) == True. This change
seems like it would end up producing more inconsistencies with the way
you deal with headers, by producing special cases.
--Jesse
next prev parent reply other threads:[~2011-05-09 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 7:06 [PATCH] python/thread: always return a string in get_subject/authors Anton Khirnov
2011-05-09 12:10 ` Austin Clements
2011-05-09 12:20 ` David Bremner
2011-05-09 12:57 ` servilio
2011-05-09 15:13 ` Anton Khirnov
2011-05-09 15:23 ` Jesse Rosenthal [this message]
2011-05-09 15:26 ` Jesse Rosenthal
2011-05-10 1:00 ` Sebastian Spaeth
2011-05-10 1:18 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4dzc2zf.fsf@gogo.home \
--to=jrosenthal@jhu.edu \
--cc=anton@khirnov.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).