From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F33AF429E25 for ; Thu, 23 Jun 2011 14:38:43 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cotK-6JhMG5H for ; Thu, 23 Jun 2011 14:38:43 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 89450431FD0 for ; Thu, 23 Jun 2011 14:38:43 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 9133B29A505; Thu, 23 Jun 2011 14:38:42 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 83007254157; Thu, 23 Jun 2011 14:38:42 -0700 (PDT) From: Carl Worth To: notmuch@notmuchmail.org, David Bremner Subject: Re: debian: Override RPATH_LDFLAGS In-Reply-To: <20110623014835.13916431FD0@olra.theworths.org> References: <20110623014835.13916431FD0@olra.theworths.org> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Thu, 23 Jun 2011 14:38:42 -0700 Message-ID: <87k4ccdy8t.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 21:38:44 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 22 Jun 2011 18:48:34 -0700 (PDT), (David Bremner) wrote: > Probably there is a nicer way to do this; perhaps it should be a > configure option. > (cherry picked from commit 387dc520dd68cc805e390f3a1399f85b5d5bd83a) This nicer way involved automatic detection of when rpath is needed. That was the intent always, but it was broken for a while, (leading to this patch I believe). The automatic detection should actually be working now. See the commit referenced below. So, you'll want to test it, of course, but I think you can (and should) drop this override of RPATH_LDFLAGS from the Debian packaging now. =2DCarl commit 574f408816e636f677b14384c18cc2e388991411 Author: Carl Worth Date: Wed Jun 1 13:02:58 2011 -0700 configure: Fix detection of libdir in ldconfig configuration =20=20=20=20 Ever since commit b4b5e9ce4dac62111ec11da6d22b7e618056801f the detection of libdir in the ldconfig configuration has been broken, resulting in RPATH being set when not needed and not wanted. =20=20=20=20 The cause was a change from an IFS setting of: =20=20=20=20 IFS=3D"$(printf '\n\t')" =20=20=20=20 to a new setting of: =20=20=20=20 IFS=3D"$(printf '\n')" =20=20=20=20 That looks desirable since we want to split the output of ldconfig based on newlines, (and not split on any filename that might have an embedded tab in it). The subtle bug in the above is that the shell trims any trailing newlines when performing command substitution so the final statement above was equivalent to: =20=20=20=20 IFS=3D'' =20=20=20=20 which prevented any splitting of the ldconfig output at all. =20=20=20=20 Fix this by avoiding command substitution and just using a literal newline in the source file for setting this variable. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4DsmIACgkQ6JDdNq8qSWgU1ACdHNskbxWlmB49nmeCV1jB+awh ulkAn0jVmSFIOLrM/8gLItGcnrdYEu8f =aaav -----END PGP SIGNATURE----- --=-=-=--