On Wed, 21 Dec 2011 23:43:09 -0400, David Bremner <david@tethera.net> wrote:
> The man pages are now installed, a notmuch help (built from this branch)
> uses them.

Hey, David this is really great.  Thank you so much for working on this.
This will make things much easier to maintain down the line.

I think what you've done looks great.  A couple small issues:

* There are a couple of formatting issues (notmuch.1, notmuch-config.1,
  notmuch-reply.1).

* The notmuch part command is completely deprecated, so I don't think
  there's really any reason to include a man page for it.

* There's no man page for restore (notmuch-restore.1).

It also occurs to me while looking through this: do we really need a
separate "setup" command?  Does that ever really get run?  Doesn't
notmuch new run the setup if it doesn't detect a config?  If there's
really reason to run it again at a later point, why don't we just have a
--setup option to notmuch new instead?  It would also make notmuch.1
cleaner if we removed it.

> I'm not sure if posting the patches make sense; it's up to 74k of diffs,
> even using "git format-patch -D".  I'm open to suggestions, as always.

While in general I think it's nice to have patches to the list, but I'm
not sure how much benefit there is in this case.  I would be fine to
just see the patch merged directly from your branch.

Again, thanks for the work on this, David.  This 

jamie.