Re: [PATCH] rewriting notmuch-search for structured output to make other output formats easier

[Jameson Graef Rollins <jrollins@finestructure.net>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Sat, 21 Jan 2012 22:16:08 +0100, Peter Feigl <craven@gmx.net> wrote:
> The output routines have been rewritten so that logical structure
> (objects with key/value pairs, arrays, strings and numbers) are
> written instead of ad-hoc printfs. This allows for easier adaptation
> of other output formats, as only the routines that start/end an object
> etc. have to be rewritten. The logic is the same for all formats.
> The default text output is handled differently, special cases are
> inserted at the proper places, as it differs too much from the
> structured output.

Hi, Peter.  Thanks for the contribution.

There are a lot of changes in this patch so I think you need to think
about how you can break this up into multiple smaller and more atomic
patches.  In particular, the addition of the sexp output format needs to
definitely be in a separate patch from the restructuring of the output
formatting.  You also don't mention anywhere in the commit log that
you've added this new output format.  You'll also need to include
documentation and test suite updates.

Thanks.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]