From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 92CE1431E64 for ; Wed, 1 Feb 2012 02:39:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qvY-Nv8xin0m for ; Wed, 1 Feb 2012 02:39:09 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 487C5431FAF for ; Wed, 1 Feb 2012 02:39:09 -0800 (PST) Received: by bke11 with SMTP id 11so976544bke.26 for ; Wed, 01 Feb 2012 02:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=0B5V+AyRbQKBVL2h1R3R06jP6PYH7gD3L+Jn9NUhfXE=; b=DjzReOL5+ySOCTONoDA3QFyldiffjiDebJ9Ls5VroaersiHAtp15DCGK0tO3mk8tVc 8K6YmVLUUtJWFGvj02hdr14ct1nJSzOEs+kzSTiLqDdNkCndWJmgpq2wvBwS8LqR0pDx JVSnCC6wSZRJJcV2jf+1mFKyuXjz9UxN0nMTw= Received: by 10.205.123.2 with SMTP id gi2mr12908554bkc.76.1328092746304; Wed, 01 Feb 2012 02:39:06 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id o26sm46985782bko.14.2012.02.01.02.39.05 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Feb 2012 02:39:05 -0800 (PST) From: Dmitry Kurochkin To: Tomi Ollila , Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible In-Reply-To: References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> <87r4yfszx9.fsf@servo.finestructure.net> <87pqdync64.fsf@gmail.com> User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 01 Feb 2012 14:37:53 +0400 Message-ID: <87k446n8ji.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2012 10:39:11 -0000 On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila wrote: > > There are at least these options here > > 1) go through all ~100 places where test_expect_equal_file is used > and fix the call order: quick look tells that the offending uses > are in dump-restore, hooks, search-limiting and symbol-hiding. > > 2) enforce "expected" filename has some format *and* fix all current > uses of it. Add testbed_error () function which yells loudly ane exits... > > 3) guess which is output and which is expected from args so that > machine helps tester here (for both diff output & copied files)a > > 4) just copy compared files to some directory, those are named as > basename of the original -- diff order still inconsistent. > > > I'd just go with option 1 and fix new *violations* when stumble upon one. > Option 1 does not solve the problem. New violations would apper and need to be fixed again. I am for option 2. Regards, Dmitry > Tomi