From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Pieter Praet <pieter@praet.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'
Date: Fri, 12 Oct 2012 17:36:31 -0400 [thread overview]
Message-ID: <87k3uv9xuo.fsf@betacantrips.com> (raw)
In-Reply-To: <1329936214-30959-3-git-send-email-pieter@praet.org>
Pieter Praet <pieter@praet.org> writes:
> * emacs/notmuch-show.el
>
> (notmuch-show-toggle-headers):
> Rename to `notmuch-show-toggle-visibility-headers'.
This patch, and its predecessors, all look great to me. The following
patches were already marked "stale" (and indeed they don't apply). But
it looks like David Edmonson gave his +1 on the idea, so maybe you
should rebase them.
Side note: how do you write these tests? How do you generate what the
output should look like? Copy/paste from a "real" emacs session? You
have generated an awful lot of tests :)
Ethan
next prev parent reply other threads:[~2012-10-12 21:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 5:25 [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility Pieter Praet
2012-01-25 6:35 ` David Edmondson
2012-01-25 13:03 ` Tomi Ollila
2012-01-26 13:02 ` Pieter Praet
2012-01-26 15:04 ` David Edmondson
2012-01-26 15:58 ` Tomi Ollila
2012-02-13 10:51 ` Dmitry Kurochkin
2012-02-22 18:41 ` Pieter Praet
2012-02-22 18:43 ` [PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers" Pieter Praet
2012-10-20 20:40 ` David Bremner
2012-02-22 18:43 ` [PATCH v2 2/7] test: emacs: new tests "notmuch-show: {, un}collapse all messages in thread" Pieter Praet
2012-02-22 18:43 ` [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' Pieter Praet
2012-10-12 21:36 ` Ethan Glasser-Camp [this message]
2012-10-18 0:29 ` Ethan Glasser-Camp
2012-10-18 9:47 ` Tomi Ollila
2012-10-18 9:50 ` Tomi Ollila
2012-10-18 13:37 ` Ethan
2012-10-18 13:59 ` Tomi Ollila
2012-02-22 18:43 ` [PATCH v2 4/7] emacs: rename `notmuch-show-toggle-message' to `notmuch-show-toggle-visibility-message' Pieter Praet
2012-02-22 18:43 ` [PATCH v2 5/7] emacs: rename `notmuch-show-open-or-close-all' to `notmuch-show-toggle-visibility-messages' Pieter Praet
2012-02-22 18:43 ` [PATCH v2 6/7] emacs: make `notmuch-show-toggle-visibility-messages' live up to its new name Pieter Praet
2012-02-22 18:43 ` [PATCH v2 7/7] emacs: `notmuch-show-toggle-visibility-messages' with prefix arg filters by tag Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3uv9xuo.fsf@betacantrips.com \
--to=ethan.glasser.camp@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=pieter@praet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).