unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] cli: mime node: abstract decryption and signature verification
Date: Fri, 29 Mar 2013 19:05:54 -0400	[thread overview]
Message-ID: <87k3opiz71.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <d250faaac8aae1f6383b7a77e84e4b4144791688.1362319765.git.jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> The code filled with #ifdef GMIME_ATLEAST_26 is difficult to
> read. Abstract the decryption and signature verification into
> functions, with separate implementations for GMime 2.4 and 2.6, to
> clarify the code.

This series mostly looks OK, although it's a challenge to track all the
code movement.

I'd like some way to make it more obvious to the reader which version of
the functions they are reading (when the #ifdef GMIME_ATLEAST_26 has
scrolled off screen). The simplest would just be a comment in front of
each function.

d

  reply	other threads:[~2013-03-30  1:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-03 14:10 [PATCH 1/2] cli: crypto: abstract gpg context creation for clarity Jani Nikula
2013-03-03 14:10 ` [PATCH 2/2] cli: mime node: abstract decryption and signature verification Jani Nikula
2013-03-29 23:05   ` David Bremner [this message]
2013-03-30 13:17     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3opiz71.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).