From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Mark Walters <markwalters1009@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4] rename pick to tree
Date: Sun, 27 Oct 2013 09:29:17 -0300 [thread overview]
Message-ID: <87k3gy523m.fsf@zancas.localnet> (raw)
In-Reply-To: <m238nnt5hl.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> LGTM. I will test (again) when the series posted to move this mainline
> is submitted.
>
> Tomi
>
Looks OK to me as well. I did notice one warning about adding whitespace
errors when applying patch 3/4. After staring at the patch a bit, I'm
pretty sure that's the usual problem that the test data actually has
trailing whitespace in it, so nothing to worry about.
d
next prev parent reply other threads:[~2013-10-27 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 22:02 [PATCH 0/4] rename pick to tree Mark Walters
2013-10-26 22:02 ` [PATCH 1/4] contrib: pick: move lisp names from " Mark Walters
2013-10-26 22:02 ` [PATCH 2/4] pick: Change the test names and print out for pick tests Mark Walters
2013-10-26 22:02 ` [PATCH 3/4] pick: rename test outputs from pick to tree Mark Walters
2013-10-26 22:02 ` [PATCH 4/4] pick: rename test emacs-pick to emacs-tree Mark Walters
2013-10-27 9:42 ` [PATCH 0/4] rename pick to tree Tomi Ollila
2013-10-27 12:29 ` David Bremner [this message]
2013-10-29 11:17 ` David Bremner
-- strict thread matches above, loose matches on Subject: below --
2013-10-26 21:21 Mark Walters
2013-10-26 21:44 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3gy523m.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).