Re: [PATCH 3/3] compact: Provide user with more error feedback

[Ben Gamari <bgamari.foss@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Oct 27 2013, Ben Gamari <bgamari.foss@gmail.com> wrote:
>
>> Provide instructions on what to do when we couldn't move the compacted
>> database into place.
>>
>> Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>
>> ---
>>  lib/database.cc | 18 +++++++++++++++++-
>>  1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/database.cc b/lib/database.cc
>> index 57c2292..6f9fed1 100644
>> --- a/lib/database.cc
>> +++ b/lib/database.cc
>> @@ -938,7 +938,23 @@ notmuch_database_compact (const char* path,
>>      }
>>  
>>      if (rename(compact_xapian_path, xapian_path)) {
>> -	fprintf (stderr, "Error moving compacted database\n");
>> +	fprintf (stderr, "Error moving compacted database into place: %s\n", strerror(errno));
>> +	fprintf (stderr, "\n");
>> +	fprintf (stderr, "Encountered error %s while moving the compacted database,\n",
>> +		 strerror(errno));
>
> You probably missed my comments in id:m2d2mz7qv7.fsf@guru.guru-group.fi ?
>
Indeed I did. My apologies. New set coming.

Cheers,

- Ben

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]