unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Gaute Hope <eg@gaute.vetsj.com>, notmuch@notmuchmail.org
Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been modified
Date: Mon, 18 Jan 2016 08:25:00 -0400	[thread overview]
Message-ID: <87k2n72hyb.fsf@zancas.localnet> (raw)
In-Reply-To: <1453106256-astroid-0-0ubhau8qws-26019@strange>

Gaute Hope <eg@gaute.vetsj.com> writes:

> Hi,
>
> a user of astroid [0] ran into a issue [1] (full trace at issue) where
> reading a long query causes a talloc_abort in notmuch_thread_get_tags
> (). 'notmuch new' is running at the same time, and most likely a thread
> in the query has been modified since the query was done. Note that a
> notmuch_thread_get_authors () call returns NULL without causing a full
> crash. The code causing the crash is:
>
> ```
>     for (tags = notmuch_thread_get_tags (nm_thread);
>          notmuch_tags_valid (tags);
>          notmuch_tags_move_to_next (tags))
>     {
>       tag = notmuch_tags_get (tags); // tag belongs to tags
>     }
>
>     // or db.cc:508 in astroid/src.
> ```
>

The most likely cause of such a crash looks to me like nm_thread is NULL
or corrupted when passed in to get_tags. It's used without checking as a
talloc context, and that call to talloc never returns.

  reply	other threads:[~2016-01-18 12:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  8:46 talloc_abort in notmuch_thread_get_tags () when db has been modified Gaute Hope
2016-01-18 12:25 ` David Bremner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-01-18 12:45 Gaute Hope
2016-03-07  9:14 ` Gaute Hope
2016-03-07 12:01   ` David Bremner
2017-02-15 22:58     ` Gaute Hope
2017-02-17 12:28       ` David Bremner
2017-02-17 14:01         ` Gaute Hope
2017-02-17 15:35           ` David Bremner
2017-11-03 10:45             ` Gaute Hope
2017-11-03 12:02               ` Gaute Hope
2017-11-03 12:18                 ` David Bremner
2017-11-03 12:50                   ` Gaute Hope

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2n72hyb.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=eg@gaute.vetsj.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).