From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7CA1B6DE0A73 for ; Fri, 19 Aug 2016 05:18:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8JEOZzGNy2MJ for ; Fri, 19 Aug 2016 05:18:56 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id ABAD56DE098A for ; Fri, 19 Aug 2016 05:18:56 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bailM-0000pt-MZ; Fri, 19 Aug 2016 08:19:04 -0400 Received: (nullmailer pid 14580 invoked by uid 1000); Fri, 19 Aug 2016 12:18:51 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH] lib: reword comment about XFOLDER: prefix In-Reply-To: <1471508311-21806-1-git-send-email-david@tethera.net> References: <1471508096-19252-1-git-send-email-david@tethera.net> <1471508311-21806-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 19 Aug 2016 09:18:51 -0300 Message-ID: <87k2fdq7dg.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 12:18:57 -0000 David Bremner writes: > I believe the current one is misleading, because in my experiments > Xapian did not add : when prefix and term were both upper case. Indeed, > it's hard to see how it could, because prefixes are added at a layer > above Xapian in our code. See _notmuch_message_add_term for an example. > > Also try to explain why this is a good idea. As far as I can ascertain, > this is more of an issue for a system trying to work with an unknown set > of prefixes. Since notmuch has a fixed set of prefixes, and we can > hopefully be trusted not to add XGOLD and XGOLDEN as prefixes, it is > harder for problems to arise. pushed, d