From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B450C6DE0352 for ; Mon, 5 Jun 2017 06:01:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.053 X-Spam-Level: X-Spam-Status: No, score=-0.053 tagged_above=-999 required=5 tests=[AWL=-0.053] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wKRONBgw3XO2 for ; Mon, 5 Jun 2017 06:01:00 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 9B0336DE01C2 for ; Mon, 5 Jun 2017 06:01:00 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id B3A54F99B; Mon, 5 Jun 2017 09:00:57 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id C42A62123D; Sun, 4 Jun 2017 16:34:44 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , notmuch@freelists.org, notmuch@notmuchmail.org Subject: Re: [patch v3 06/12] lib: index message files with duplicate message-ids In-Reply-To: <20170604123235.24466-7-david@tethera.net> References: <20170604123235.24466-1-david@tethera.net> <20170604123235.24466-7-david@tethera.net> Date: Sun, 04 Jun 2017 16:34:38 -0400 Message-ID: <87k24rebkx.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2017 13:01:02 -0000 --=-=-= Content-Type: text/plain On Sun 2017-06-04 09:32:29 -0300, David Bremner wrote: > The corresponding xapian document just gets more terms added to it, > but this doesn't seem to break anything. Values on the other hand get > overwritten, which is a bit annoying, but arguably it is not worse to > take the values (from, subject, date) from the last file indexed > rather than the first. It's certainly a change in behavior, though. This suggests that i can send you mail and have it change how an existing message shows up in the summary view, for example. for example, i could follow up on the current message with another message with Message-Id: 20170604123235.24466-7-david@tethera.net and give it a subject "Re: [patch v3 06/12] lib: do *not* index message files with duplicate message-ids". that's a bit odd, no? I'm not saying it's wrong, i'm just hoping to acknowledge that this might be a controversial change. this whole series is pretty elaborate, of course, but so far it's looking like reasonable steps toward a clearer and more hackable codebase. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOCdgUepHf6PklTkyFJitxsGSMjcFAlk0bt4ACgkQFJitxsGS MjdFcRAAgIpsJPtlXSBvZkf9magAG5ZWZBsLsyoVxNifvXj9vX2ajhhjdpc87dGp Y1FzOJVAYPxUVIbl9ZSIwsRc+f3vvgCq0dQsyh+fK1KLlO0uHHBkFmlyBgEoa2Lt L1mgwvCeaaZLLq1T/YlGdwlztK1JnOWehNcXuvQQN3YlNoDtSpWJlsSXJFKVV/EL 6754RDpbg0y70fKIK6qp+fw4uPmhW0SqoXBdm8BPscXnVLE/QTVzrd8nF+fxEVnZ BL0y4L32AOFg+d7Mbw9AkkztAQ0C6dd3cBjiVliiOlZ8rguHq7JAgcBEpsiiEntG aryf8gwK0AOuNteCYopVQnGRzzkJkplk7MiDne9ncL5ZcLTr5+6Ra8JpYn0MoMmP kVyBNnQyZ3Eo56ha4dHUXl/ygorPPLh14exRZVG6CpomnhlWYxi8S8UPUo8eAVFz GAvkwKIFjvwSTz+oqb92YJSV6e6NPGyPtO9g/PCxaryAA4S15Chb9NuM6Sjm1imW lW9U7NgHnVyB0FSMlk3cYwkYTJ73QeWeH3kwckIZfEWRQfSF/1qLCEjk5bUTqeIT uDjpTWymuuOCVflZ3AFRq8PNQO+mAOcZSg4Ljd0OeSnJb8XlZpzWW1Lwx4C3AOFI REZocttnmU/QlhDG8dss58/tUxdITsJAFqGRTNMH1a1DUqWpghE= =bSkx -----END PGP SIGNATURE----- --=-=-=--