From: David Bremner <david@tethera.net>
To: Sebastian Poeplau <sebastian.poeplau@eurecom.fr>,
Jeffrey Stedfast <jestedfa@microsoft.com>,
"notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: Handling mislabeled emails encoded with Windows-1252
Date: Tue, 31 Jul 2018 17:07:03 +0800 [thread overview]
Message-ID: <87k1pbg4eg.fsf@tethera.net> (raw)
In-Reply-To: <87tvohxiz8.fsf@eurecom.fr>
Sebastian Poeplau <sebastian.poeplau@eurecom.fr> writes:
>> Nice, I'll add it.
>
> Updated patch attached.
>
> Cheers,
> Sebastian
Thanks to both of you for working on this. The code looks ok to me, I
have only some procedural comments.
In order to merge it I'll need at least one test. I think
test/T300-encoding.sh is probably the right place. There are a few
different styles of test; you can either put things in variables as in
that file, or use the more dominant
test_subtest_begin_test "description"
cat << EOF > EXPECTED
this is my expected output
EOF
notmuch show STUFF > OUTPUT
test_expect_equal_file EXPECTED OUTPUT
Feel free to bug the list for help on making tests (or #notmuch on
freenode).
Please also use git-send-email to send your patch(es), with commit
messages with an eye to
https://notmuchmail.org/contributing/#index5h2
To minimize the chance of problems, it's probably best to base your
commits on master, although the patch you sent applied fine here.
Thanks,
David
next prev parent reply other threads:[~2018-07-31 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 12:40 Handling mislabeled emails encoded with Windows-1252 Sebastian Poeplau
2018-07-24 1:49 ` David Bremner
2018-07-24 8:00 ` Sebastian Poeplau
2018-07-24 13:55 ` Sebastian Poeplau
2018-07-24 14:09 ` Jeffrey Stedfast
2018-07-24 14:19 ` Sebastian Poeplau
2018-07-28 11:22 ` Sebastian Poeplau
2018-07-28 12:25 ` Jeffrey Stedfast
2018-07-30 7:28 ` Sebastian Poeplau
2018-07-30 7:47 ` Sebastian Poeplau
2018-07-31 9:07 ` David Bremner [this message]
2018-07-31 9:49 ` Sebastian Poeplau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1pbg4eg.fsf@tethera.net \
--to=david@tethera.net \
--cc=jestedfa@microsoft.com \
--cc=notmuch@notmuchmail.org \
--cc=sebastian.poeplau@eurecom.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).