From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D443F6DE0F74 for ; Sat, 23 Mar 2019 07:45:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.016 X-Spam-Level: X-Spam-Status: No, score=-0.016 tagged_above=-999 required=5 tests=[AWL=-0.015, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K2J7klvmOIUX for ; Sat, 23 Mar 2019 07:45:17 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B2E136DE0F37 for ; Sat, 23 Mar 2019 07:45:17 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1h7hta-0000Mx-GW; Sat, 23 Mar 2019 10:45:14 -0400 Received: (nullmailer pid 29023 invoked by uid 1000); Sat, 23 Mar 2019 14:45:13 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: Daniel Kahn Gillmor Subject: renamimg mime_node_* to notmuch_mime_node_* X-List-To: notmuch Date: Sat, 23 Mar 2019 11:45:13 -0300 Message-ID: <87k1gp4pl2.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Mar 2019 14:45:18 -0000 I've started working on allowing gzipped message files. The access in libnotmuch is relatively centralized in message-file.c, and I've managed to convert that to allow gzipped files [1]. However this is still direct file access in the notmuch CLI, and at least mime-node.c and notmuch-show.c will need to be updated. notmuch-show looks like a simple gzopen / gzreadline substitution can do the trick, but mime-node.c will require the same slightly trick work as I already did in lib/message-file.c (_message_file_open_stream). I'd like to avoid duplicate that. There seems to be two approaches: export some of the _notmuch_message_file API and re-use that in mime-node.c, or put the mime_node_* functions in the library. I'm not sure yet which of these options is cleaner; I'd prefer not to expose GMime types as part of the libnotmuch API. Does anyone have any arguments either way? Perhaps some other motivation for pushing the mime-node stuff into libnotmuch? CC'ing dkg as the last person to meaningfully edit mime-node.c [1]: the (very) WIP is available at https://salsa.debian.org/bremner/notmuch/tree/wip/gzip