From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 908BF6DE0E8C for ; Tue, 2 Apr 2019 02:13:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -2.694 X-Spam-Level: X-Spam-Status: No, score=-2.694 tagged_above=-999 required=5 tests=[AWL=-0.192, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5B2KSM46fI8N for ; Tue, 2 Apr 2019 02:12:56 -0700 (PDT) Received: from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193]) by arlo.cworth.org (Postfix) with ESMTPS id 6F2336DE0E7E for ; Tue, 2 Apr 2019 02:12:56 -0700 (PDT) Received: from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-4.sys.kth.se (Postfix) with ESMTP id 77E388FD; Tue, 2 Apr 2019 11:12:52 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-4.sys.kth.se ([127.0.0.1]) by smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dXJbOka1iMU1; Tue, 2 Apr 2019 11:12:51 +0200 (CEST) X-KTH-Auth: ekeberg [85.229.204.229] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1554196371; bh=k37y2PTYf885Ho2uFzLIzHw7RbGZIb7M+//sDXbT4g0=; h=From:To:Subject:In-Reply-To:References:Date; b=hY7kjuCP6fn4EdWkXxZU0GgP+WDKWCdc62+v8NeiNjYpUb18XtpJca/25j8Xl5kdn VtRs+DLtesEtoEslfr6g/QFbCh2ecuDsUQtquRo518GLyHCKClfh6QAi9z3TmGsyio 3GstIa0BG1Glt8oHf/Z/iafFwWp3Roz2OpmaKEvc= X-KTH-mail-from: ekeberg@kth.se Received: from swing (c-e5cce555.09-723-73746f39.bbcust.telenor.se [85.229.204.229]) by smtp-4.sys.kth.se (Postfix) with ESMTPSA id 3C93B1E3; Tue, 2 Apr 2019 11:12:49 +0200 (CEST) From: =?utf-8?Q?=C3=96rjan?= Ekeberg To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable In-Reply-To: References: <20190330214821.4150-1-ekeberg@kth.se> Date: Tue, 02 Apr 2019 11:12:49 +0200 Message-ID: <87k1gcvkha.fsf@swing.csc.kth.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 09:13:16 -0000 Tomi Ollila writes: > two things > > - I wonder whether we could drop (defun notmuch-message-mark-replied ()..= .) > - why is it needed for backward compatibility ? Yes, it would be cleaner to simply remove it. My thought was that there is a slight risk that someone is explicitly using or manipulating this function in some personal code. This is probably very unlikely, so I am more than happy to drop it. >=20=20 > - A test of a few would be nice to see how this behaves -- and we can see > that this still works e.g. on emacs 24... Indeed. I did consider this, but since I am not at all familiar with how to write such tests, I did not proceed with this. /=C3=96rjan