From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 4A29A6DE10B6 for ; Wed, 1 May 2019 13:35:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.032 X-Spam-Level: X-Spam-Status: No, score=-0.032 tagged_above=-999 required=5 tests=[AWL=-0.031, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEix_g21-7bm for ; Wed, 1 May 2019 13:35:53 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 6AB8A6DE1037 for ; Wed, 1 May 2019 13:35:53 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hLvxI-0004AD-FF; Wed, 01 May 2019 16:35:52 -0400 Received: (nullmailer pid 5241 invoked by uid 1000); Wed, 01 May 2019 20:35:51 -0000 From: David Bremner To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: [PATCH] build: drop support for gmime-2.6 In-Reply-To: <87d0l2oruf.fsf@fifthhorseman.net> References: <20190501104643.5836-1-david@tethera.net> <87d0l2oruf.fsf@fifthhorseman.net> Date: Wed, 01 May 2019 17:35:51 -0300 Message-ID: <87k1f9nc9k.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 20:35:54 -0000 Daniel Kahn Gillmor writes: > On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote: >> GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in >> notmuch for about 1.5 years. > > I was just looking at this change myself. > > As a gmime maintainer in debian, I'd love to see it happen, but i think > the right way to do that is to prune/reverse many of the versioned > translations in util/gmime-extra.h, so that we're using the "native" > gmime 3.0 API, rather than a mishmash of the 2.6 and 3.0 API. > > And we should probably tear out all the #if (GMIME_MAJOR_VERSION < 3) > stanzas in the source as well. > > --dkg I was thinking of a minimal change now, so it isn't blocking other things, and then a gradual cleanup. d