From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E24D56DE0EB0 for ; Tue, 28 May 2019 15:55:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.177 X-Spam-Level: X-Spam-Status: No, score=-0.177 tagged_above=-999 required=5 tests=[AWL=0.024, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPSAIjy350su for ; Tue, 28 May 2019 15:55:07 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 33C1F6DE1050 for ; Tue, 28 May 2019 15:55:06 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1559084103; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=8bRTBwK0+UolDW1u63SmCl+W1CuJx31T7HuoU5l9nz8=; b=21JrWIVjoKdt5y3OQKKkwHuy6DmV1WY9ecsKca8jufh2aSduuGbmdLXu uzy0NgsG4GsIIoB4e3Zy/YmEIIT5Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1559084103; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=8bRTBwK0+UolDW1u63SmCl+W1CuJx31T7HuoU5l9nz8=; b=yOtBlAC6h5ywNR9AGCfXVaHslVuWwkCOZAMTP9BxQa2gGRQO5HGjAXq2 ZBAn1LnJvVHXsDX6gL4AjHMObMzaGoFfoEGT4mIUr37nzUIpyFtU7Ihkuq Umy4P4s9+e9EbcLnK0LNt9MY2UG0qanvXi3eQW49Hz1N5O+pXJKa+cnc3q 8dz+LxSEtNkElLw/obVk8XPdHD2fFI7XaRwe75InjU6D8e7xnok/gpHY4u u6KrusnkOgbInUqeqvWjl2wtDQgBHes+mVlaEfMErZptMlIwK2Ltrnzilx lPPtGW5OMi3G8sCQJH/xebNw/BQfQW2+a6J49Ukr0eIaBvabpRyXeA== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 10FC0F9A1; Tue, 28 May 2019 18:55:02 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 24CFE20609; Tue, 28 May 2019 18:39:37 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH v4 06/17] cli/show: add information about which headers were protected In-Reply-To: <877eaavnpw.fsf@tethera.net> References: <871s0kkxy3.fsf@tethera.net> <20190527221416.9708-1-dkg@fifthhorseman.net> <877eaavnpw.fsf@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Tue, 28 May 2019 18:39:36 -0400 Message-ID: <87k1ea2ogn.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2019 22:55:08 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue 2019-05-28 08:10:35 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: >> decrypted?: { >> status: msgdecstatus, >> + # map encrypted headers that differed from the outsid= e headers. >> + # the value of each item in the map is what that fiel= d showed externally >> + # (maybe null if it was not present in the external h= eaders). >> + header-mask: { header_name: string|null,*} >> } > > Apologies for not catching this before (and for fussing so much about > the schemata file), but this notation for repeated key-value pairs > doesn't seem ideal to me. Don't apologize for your fussing -- we have good documentation in notmuch in large part because of this kind of fussiness. > I would say either > > header-mask: { (header_name: string|null)* } > header-mask: { header_name*: string|null } > > Either would need a brief explanation above, as this the first map > defined with an arbitrary number of members. I agree with you that both of your proposed notations are better than the one i'd picked initially. I'm not convinced that the explanatory text above needs to be expanded, because it is an arbitrary header_name =E2=86=92 string map and i think the text captures that idea fairly succinc= tly, but if you want to add additional text about "what does the kleene star mean here" i wouldn't object to such an explanation. So, I'm fine with either proposed notation, and i think you and i have the same mental model of what this is supposed to be, so i trust you to choose one of them and to write any additional text. Is it ok if i punt that decision to you? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXO24qAAKCRB2GBllKa5f +PZyAQD5IOKKZkcllxje+arOr5Mvh2MxkYHLKHhfKK1bheDZ0QEAqlXVyNnOHKIQ je3dheaNf1tjALijkBr4wpce6jQsIQg= =R3QK -----END PGP SIGNATURE----- --=-=-=--