From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7F4F36DE10AA for ; Wed, 4 Dec 2019 11:15:25 -0800 (PST) Authentication-Results: arlo.cworth.org; dkim=pass (2048-bit key; secure) header.d=jb55.com header.i=@jb55.com header.b="EfgcVuuu"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.363 X-Spam-Level: X-Spam-Status: No, score=-0.363 tagged_above=-999 required=5 tests=[AWL=-0.163, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2yxc3a12F_qI for ; Wed, 4 Dec 2019 11:15:25 -0800 (PST) Received: from jb55.com (jb55.com [45.79.91.128]) by arlo.cworth.org (Postfix) with ESMTPS id BC0356DE1055 for ; Wed, 4 Dec 2019 11:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d= jb55.com; h=from:to:subject:date:message-id; s=default; bh=AP2jK4s9mASg24Om5jWVKLRBnKVP1odttDF53+3Jpd4=; b=EfgcVuuuuJaF6Mc81dsGP3uHult9F7oR/2fSege/obHjNdWkx+XGwAP9f7fDXb2Mwy9dfGySG/WxuWk0VtQtjXUVMRwv1w469f3HyLz2PEDrn6kcgPnuQuKsEplh4W4GzUqwsa0eCwn8TnXBMinX67YrAV1Q6sV+m+v9p/hFqt2XIoanbxLezVZFw6v4NAQRWPkFGtQbBxWHkwbGk30abdnd9UrUa4AYlzVL80lJnEcJCadpkO05vKKQxdG1aT0u/UHdGpWjjFbhyqiCHeEDFiXslADdLUReXIa9PBU+QsyTFpU8X2qsfIUdaFonztjcShUdDZk7UXrFd8CQxw6Wxg== Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id 582409cd TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 4 Dec 2019 19:15:24 +0000 (UTC) From: William Casarin To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message In-Reply-To: References: <20191128161401.28844-1-jb55@jb55.com> <20191128161401.28844-3-jb55@jb55.com> Date: Wed, 04 Dec 2019 11:15:23 -0800 Message-ID: <87k17brjg4.fsf@jb55.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2019 19:15:25 -0000 David Edmondson writes: > On Thursday, 2019-11-28 at 08:13:55 -08, William Casarin wrote: > >> This function captures some common logic when jumping to matching >> messages in notmuch-tree mode. >> >> We also add a new return value (t or nil), that indicates if there was >> a next matching message in the thread to show. >> >> Signed-off-by: William Casarin >> --- >> emacs/notmuch-tree.el | 17 +++++++++++++---- >> 1 file changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el >> index 4bc05160..9f2d87b5 100644 >> --- a/emacs/notmuch-tree.el >> +++ b/emacs/notmuch-tree.el >> @@ -577,12 +577,22 @@ message will be \"unarchived\", i.e. the tag changes in >> (when (window-live-p notmuch-tree-message-window) >> (notmuch-tree-show-message-in))) >> >> +(defun notmuch-tree-goto-matching-message (&optional prev) >> + "Move to the next or previous matching message. >> + >> +Returns t if there was a next matching message in the thread to show, >> +nil otherwise." >> + (let (last) >> + (while (and (not (setq last (if prev (bobp) (eobp)))) >> + (not (notmuch-tree-get-match))) >> + (forward-line (if prev -1 nil))) > > A function scope variable to store the direction would save testing > `prev' every time around the loop. > > Same question about the local variable as for the last patch. yup I believe this makes sense, I send out a new version in a bit. > >> + (not last))) >> + >> (defun notmuch-tree-prev-matching-message () >> "Move to previous matching message." >> (interactive) >> (forward-line -1) >> - (while (and (not (bobp)) (not (notmuch-tree-get-match))) >> - (forward-line -1)) >> + (notmuch-tree-goto-matching-message t) >> (when (window-live-p notmuch-tree-message-window) >> (notmuch-tree-show-message-in))) >> >> @@ -590,8 +600,7 @@ message will be \"unarchived\", i.e. the tag changes in >> "Move to next matching message." >> (interactive) >> (forward-line) >> - (while (and (not (eobp)) (not (notmuch-tree-get-match))) >> - (forward-line)) >> + (notmuch-tree-goto-matching-message) >> (when (window-live-p notmuch-tree-message-window) >> (notmuch-tree-show-message-in))) >> >> -- >> 2.23.0 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> https://notmuchmail.org/mailman/listinfo/notmuch > > dme. > -- > Oh by the way, which one's Pink?