From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SLxJEZGY7F63OAAA0tVLHw (envelope-from ) for ; Fri, 19 Jun 2020 10:50:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yFwoDZGY7F5+YAAAbx9fmQ (envelope-from ) for ; Fri, 19 Jun 2020 10:50:57 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A2BF940667 for ; Fri, 19 Jun 2020 10:50:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 199736DE104A; Fri, 19 Jun 2020 03:50:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lk6Nu1VpMPEk; Fri, 19 Jun 2020 03:50:51 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id E11B56DE101A; Fri, 19 Jun 2020 03:50:50 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7F8726DE101A for ; Fri, 19 Jun 2020 03:50:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TRn6CM7qJPSQ for ; Fri, 19 Jun 2020 03:50:48 -0700 (PDT) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by arlo.cworth.org (Postfix) with ESMTPS id BAE3E6DE0F9A for ; Fri, 19 Jun 2020 03:50:48 -0700 (PDT) Received: by mail-ed1-f68.google.com with SMTP id o26so7271426edq.0 for ; Fri, 19 Jun 2020 03:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:references:date:message-id :mime-version; bh=JqVlHYUWctTxFpBcZVOSk4+z1dlhzDXi2a0fepMaREc=; b=ise9yYxSugyeuaD5gZC3r0ccK4junDRSiLOAyJq3573SP9XtIpZE6xzYJ3jRKmjNtQ aBx52I/6ajYnGJVgGHYxJjRnBcuJDNM3TaHpHG/dY7Y9z54YBmFOGJVAabpkURDLVngm 6P9nUEI3JTgzivRrgkgWA5kv6jAWptUAlRRgUBMC4oIsFCcD/Ad/1CWGyf8MbhlWk9T6 UylC1LOZPI9QzxUWANeit4cjCbH4uSVS9v3UrJd5IbyPTvRLNrs3zURnoRctA5mv+PSb sPocbt2acqRiZduYR3PDGVXW6kfJ0SxPCpJdOsvQ2kJM8OHja4jWnIZcKx01Tp8sov58 dxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :date:message-id:mime-version; bh=JqVlHYUWctTxFpBcZVOSk4+z1dlhzDXi2a0fepMaREc=; b=PNrU7HF3KxIu/Y+r7mT+N51sFxxiNzNQVT9UHo16DPLy9uvHfNMI4YjhaWKXJt/sCP TALkPciIMn+cDOXAm+Sw5TAGiz4Wh7ht9gHFWzWGnKkUvqC+w2NaMa6Z08VaNt7rw6NK YyScRvUgOESfpP0hwF4prMqV9KOWpZ25ejTRbIQuTle5di2G7xLzcwgaMgUJOnrKE8Re 7wBXeYoIAj/R2qtx7iWwF+mcP/4H1F3vkUfUX/zv1pL742iMNcBVlE3BIOWqOfAfObVf ReGsk0fMD99wMftrcxZxpf654gfFJZU5FJrRF+zv1KKHnXTRUNU0/4PZFopucE1Bh3Xs a1CQ== X-Gm-Message-State: AOAM533/shHIzThZk8GdeQDQvKs/dUAlpgJpZgqukJEPOVSjIgXJGz5z mZDnFGNyVk/dhhtbI/K6m5CAv25M X-Google-Smtp-Source: ABdhPJwpY+jCkk811GbwrvU5UaE8V0CEepGbqI2Ly5amwwMICD3E0UELjMed6jZr0e5QvGGU4ffa4w== X-Received: by 2002:a05:6402:1486:: with SMTP id e6mr2544060edv.99.1592563847347; Fri, 19 Jun 2020 03:50:47 -0700 (PDT) Received: from powell.devork.be (2a02-8388-8480-1180-4c18-fc69-8d8c-22b5.cable.dynamic.v6.surfer.at. [2a02:8388:8480:1180:4c18:fc69:8d8c:22b5]) by smtp.gmail.com with ESMTPSA id a24sm4423787ejc.109.2020.06.19.03.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 03:50:46 -0700 (PDT) Received: (nullmailer pid 368466 invoked by uid 1000); Fri, 19 Jun 2020 10:50:45 -0000 From: Floris Bruynooghe To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] python-cffi: read version from notmuch version file In-Reply-To: <874kr78ihc.fsf@zancas> References: <20200619094627.360612-1-flub@devork.be> <20200619094627.360612-2-flub@devork.be> <874kr78ihc.fsf@zancas> Date: Fri, 19 Jun 2020 12:50:45 +0200 Message-ID: <87k103cosa.fsf@powell.devork.be> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=ise9yYxS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.01 X-TUID: fF/MMZWFrchY On Fri 19 Jun 2020 at 07:20 -0300, David Bremner wrote: > Floris Bruynooghe writes: > BTW I noticed something (setuptools?) translates "0.30~rc2" to > "0.30-rc2". I assume that is as intended, and there are some stricter > rules for python module versions. It should only affect pre-release > versions in any case. Supposedly setuptools uses packaging.version: $ python3 Python 3.8.3 (default, May 14 2020, 11:03:12) [GCC 9.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import packaging.version >>> rc1 = packaging.version.parse('0.30~rc1') >>> rc1 >>> rc2 = packaging.version.parse('0.30~rc2') >>> maj = packaging.version.parse('0.30') >>> maj >>> rc1 < rc2 < maj True So I think this is ok? Just for completeness: >>> rc1b = packaging.version.parse('0.30-rc1') >>> rc1b >>> rc1b < maj True Apparently PEP440 has the full details of how Python wants to see version numbers work, but it's too many years ago that I read that thing ;). This seems good enough to me. Cheers, Floris