From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CNTkB0Ex5l/dcQAA0tVLHw (envelope-from ) for ; Fri, 25 Dec 2020 18:36:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YF6sA0Ex5l+GWgAA1q6Kng (envelope-from ) for ; Fri, 25 Dec 2020 18:36:49 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A2DA9404D2 for ; Fri, 25 Dec 2020 18:36:48 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3831929CD0; Fri, 25 Dec 2020 13:36:43 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 856A228536 for ; Fri, 25 Dec 2020 13:36:41 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5764C5FC36; Fri, 25 Dec 2020 13:36:41 -0500 (EST) Received: (nullmailer pid 946907 invoked by uid 1000); Fri, 25 Dec 2020 18:36:40 -0000 From: David Bremner To: Johannes Larsen , notmuch@notmuchmail.org Subject: Re: python notmuch2 bindings exclude_tags not added correctly to query In-Reply-To: <160868726210.3559542.13236319044064062818@hue.johslarsen.net> References: <160868726210.3559542.13236319044064062818@hue.johslarsen.net> Date: Fri, 25 Dec 2020 14:36:40 -0400 Message-ID: <87k0t591hj.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: SLQODXNTXXWQK3GRZPBAXZUUXMIURTT2 X-Message-ID-Hash: SLQODXNTXXWQK3GRZPBAXZUUXMIURTT2 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.55 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 5A2DA9404D2 X-Spam-Score: -0.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: QUNfHv/SAkaj Johannes Larsen writes: > A typo in Database._create_query loses the exclude_tag names during the > string to utf-8 conversion. > > > The problem is fixed by this patch applied to current master (ced341e8): > > diff --git i/bindings/python-cffi/notmuch2/_database.py w/bindings/python-cffi/notmuch2/_database.py > index 5ab0f20a..868f4408 100644 > --- i/bindings/python-cffi/notmuch2/_database.py > +++ w/bindings/python-cffi/notmuch2/_database.py > @@ -581 +581 @@ class Database(base.NotmuchObject): > - tag = str.encode('utf-8') > + tag = tag.encode('utf-8') > > -- Thanks for the fix. I've included it in release 0.31.3. If you could use "git send-email" (or at least "git format-patch") for future contributions, that would decrease that chance if my bungling things. Thanks again, David