unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Johannes Larsen <mail@johslarsen.net>, notmuch@notmuchmail.org
Subject: Re: python notmuch2 bindings exclude_tags not added correctly to query
Date: Fri, 25 Dec 2020 14:36:40 -0400	[thread overview]
Message-ID: <87k0t591hj.fsf@tethera.net> (raw)
In-Reply-To: <160868726210.3559542.13236319044064062818@hue.johslarsen.net>

Johannes Larsen <mail@johslarsen.net> writes:

> A typo in Database._create_query loses the exclude_tag names during the
> string to utf-8 conversion.
>
>
> The problem is fixed by this patch applied to current master (ced341e8):
>
> diff --git i/bindings/python-cffi/notmuch2/_database.py w/bindings/python-cffi/notmuch2/_database.py
> index 5ab0f20a..868f4408 100644
> --- i/bindings/python-cffi/notmuch2/_database.py
> +++ w/bindings/python-cffi/notmuch2/_database.py
> @@ -581 +581 @@ class Database(base.NotmuchObject):
> -                    tag = str.encode('utf-8')
> +                    tag = tag.encode('utf-8')
>
> -- 

Thanks for the fix. I've included it in release 0.31.3.

If you could use "git send-email" (or at least "git format-patch") for
future contributions, that would decrease that chance if my bungling
things.

Thanks again,

David

      parent reply	other threads:[~2020-12-25 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  1:34 python notmuch2 bindings exclude_tags not added correctly to query Johannes Larsen
2020-12-24 16:08 ` Floris Bruynooghe
2020-12-25 18:36 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0t591hj.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=mail@johslarsen.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).