From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2JMAL/2y2GA8IQEAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 19:18:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GKedKv2y2GD7agAAbx9fmQ (envelope-from ) for ; Sun, 27 Jun 2021 17:18:53 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 132651C05B for ; Sun, 27 Jun 2021 19:18:53 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DE95B290ED; Sun, 27 Jun 2021 13:18:49 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id E3740290C6 for ; Sun, 27 Jun 2021 13:18:46 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id C07985FD21; Sun, 27 Jun 2021 13:18:46 -0400 (EDT) Received: (nullmailer pid 825520 invoked by uid 1000); Sun, 27 Jun 2021 17:18:45 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/2] ruby: add keyword arguments to db.query In-Reply-To: <20210524021910.92145-2-felipe.contreras@gmail.com> References: <20210524021910.92145-1-felipe.contreras@gmail.com> <20210524021910.92145-2-felipe.contreras@gmail.com> Date: Sun, 27 Jun 2021 14:18:45 -0300 Message-ID: <87k0mf1b0q.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: URLYS42FEYSVNKKKMHHJUY6X2AMUF2D6 X-Message-ID-Hash: URLYS42FEYSVNKKKMHHJUY6X2AMUF2D6 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ludovic LANGE , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624814333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=u/MgeFJk+q+M2KmtmeMgALuhCGdtp81Ydh3QSLvbIj0=; b=ZkQlA1jRnzRuZ1meYPGJDAGddbRYH2Z6ULIudHXFrqHSoIAXVGAlNUbbGZd/8a9wgI7KkY nwblyrKBCzyqOwRHklnQEtcGLZoCr4j77DBf3dKuPIqx94jwwG15fNlOiPKC1q4BUNeCpf EvotqM8sM1G39cdjz8L/HTZE2FDqCDlonYd36dUW97K9IxRTDlDXoTzQT/Gq9R4lIpXEnr SuDTaZGZxFsavQy10zk37vW6y6JOSWiFLpNJX853sv4mj7rkUdKN32mGPNTWS/z+1xyV0v 2UZ9VDANMykmyUE6bDkTy2Mkqwhh3/UD1DXfrSdbsihEJOyqqtn+QJOiPNLHOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624814333; a=rsa-sha256; cv=none; b=PE9pkLEUEDvBwGx/G3AT9hyddD+wPpuQXaofrqQxaj2cu7optjCB7xru3sJjt3RCFVtVsE PNaJJ9BQO9CfU4Hkl57guvzpNpu1CejKgd0RG0KeEN3Awl0UsGbtoTaFp9v0GVm35MzDpX CsyWO3AjOr7EzUKLtjq05Rmnna4r9WoUki/SjAAtbfwnSgSBkIQV7P8UAX0piRFPyjjdVO GImSgzUygEtxE+ZnPpzj+rl7x0V+9chKrtj0eX+E53Ysv7ewuymFQFq+QzY8KzGHHL5UJ2 mxKu3Em637ccnDd58JnbSB5dp9VXhz3Q5NjIo77sEWNDuKWyC2pVnYaMVjVRLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.57 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 132651C05B X-Spam-Score: -0.57 X-Migadu-Scanner: scn1.migadu.com X-TUID: Z3/cdfJzaXY2 Felipe Contreras writes: > That way we don't need pass them to the query object ourselves. > I have applied this change to master. As we discussed previously, I prefer to leave the sort order explicit in the tests. d