From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OHeIMVj5BmKdpgAAgWs5BA (envelope-from ) for ; Sat, 12 Feb 2022 01:03:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iKPILlj5BmKyIQEA9RJhRA (envelope-from ) for ; Sat, 12 Feb 2022 01:03:36 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1EBA03C2CE for ; Sat, 12 Feb 2022 01:03:36 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 555695F721; Sat, 12 Feb 2022 00:03:33 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id AE2705F6B5 for ; Sat, 12 Feb 2022 00:03:30 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id EED575FBD2; Fri, 11 Feb 2022 19:03:29 -0500 (EST) Received: (nullmailer pid 1649416 invoked by uid 1000); Sat, 12 Feb 2022 00:03:00 -0000 From: David Bremner To: Michael J Gruber Subject: Re: Test suite timing issues? In-Reply-To: <164458773197.3086.16103597141743611268.git@grubix.eu> References: <164458773197.3086.16103597141743611268.git@grubix.eu> Date: Fri, 11 Feb 2022 20:03:00 -0400 Message-ID: <87k0e1x87f.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: EBPP267WNIYGHJFE2X2DS453LUXYSF5P X-Message-ID-Hash: EBPP267WNIYGHJFE2X2DS453LUXYSF5P X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644624216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=XAVmWkOvrvPEgkz3UcXAZaSHqQaW4N2Pu9eqo4CrNBk=; b=IP0xXoxAebqMRT24eC8LP46ec677Za1sF6b1gbmhT1/OEAAzfFF+9OmjWB/l58OfY5bGXC 4f/de+Jx7dXSFO3NGDSIPaCRoc/q7pQX5z+p9/eVu9OruLSrn9B2BwiRcgj6ixlW5aI4AO 0wKOiCltmlgAYv17GXD3rd7jPzmdpd4FLl/Eblzy0QJlu1AOwgSj3gFkZ5h1T19wT3bbb6 vjPTYAhLXL+KA5nGHGg528gJOpZV72Y827gSDElqGwcm3Gy3vBgckYKO2hXwSieyo3t5o4 zdq15dr50LqBmT/j1tQaKUigTk/+tbbHKqpkxudJHrlVY3yVAEwxrS/PDPE8rQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644624216; a=rsa-sha256; cv=none; b=dNvBQTxelBZUxaxjFYmpDbdWFOYpb9mElPHzUXq9zzcwja/p+GGPt9TxYcwAfh+TEiysUo ZCR5uyg2sFl74cc7oogiuGrXfHkfPNh0WpYOKR6bDW1lN8uAcAnj+H58Dq3HWFrNRD+1GT GZLzmsm6EOajU7+tJQWIQnH0A0qd9oTDDqEbUkQbhplek9LfVNrAl3GPlyyTL1DFrC3XvL VdQpRbbR7JcJhpMRPQAW/0Otl7y3wuApwLz2ZEMomztDLjPDXNg+0nkvr99jNR1OJWB4v+ mU9g7eb7e26RAtM2OQuxpeEUSjrpcCoS8H6ICktSu1idXYAAepRHEuYJN1Vd3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 1EBA03C2CE X-Spam-Score: -2.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4AjlcnX5i5zc Michael J Gruber writes: > Hi there, > > I'm trying to package notmuch for Redhat's enterprise linux and clones > (EPEL, extra packages for enterprise linux). > > This looks mostly fine, including the tests, except for intermittent > failures on epel-8-s390x. They look like the below, or in tests > following those, and apparantly all have to do with "db not synced yet" > or such, so that a message one subtest creates only shows up in the db > for the next subtest. > > I've also had completely fine test runs on epel-8-s390x, but I'm > starting to wonder whether I've just been lucky so far on other > platforms ... Could it be possible that generate_message(), even though > adding the message, still returns false and therefore add_message() does > not call "notmuch new"? One might want to drop the "&&" there in > test-lib-common, I dunno. This shouldn't be "intermittent". It's hard to see what can go wrong (maybe perl doesn't work?), but failing to generate a message should be a fatal error. Maybe try something like diff --git a/test/test-lib-common.sh b/test/test-lib-common.sh index ebbf4cdf..076777ca 100644 --- a/test/test-lib-common.sh +++ b/test/test-lib-common.sh @@ -225,7 +225,7 @@ EOF # All of the arguments and return values supported by generate_message # are also supported here, so see that function for details. add_message () { - generate_message "$@" && + generate_message "$@" || error "failed to generate message" notmuch new > /dev/null } to see if you get more information