From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uCdmCrfQ5mK++QAAbAwnHQ (envelope-from ) for ; Sun, 31 Jul 2022 20:57:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cBZWCrfQ5mKD+wAAauVa8A (envelope-from ) for ; Sun, 31 Jul 2022 20:57:59 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAE0F26722 for ; Sun, 31 Jul 2022 20:57:58 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4A6175E552; Sun, 31 Jul 2022 18:57:56 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2B3FC5E541 for ; Sun, 31 Jul 2022 18:57:54 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 26EA05FBC0; Sun, 31 Jul 2022 14:57:53 -0400 (EDT) Received: (nullmailer pid 3046770 invoked by uid 1000); Sun, 31 Jul 2022 18:57:52 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch.c: add missing trailing newlines in two error messages In-Reply-To: <20220731173211.165098-1-tomi.ollila@iki.fi> References: <20220731173211.165098-1-tomi.ollila@iki.fi> Date: Sun, 31 Jul 2022 15:57:52 -0300 Message-ID: <87k07tp0sv.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 3ROOG5TA3AOZU3V43GLNQWSFTIVPZTTS X-Message-ID-Hash: 3ROOG5TA3AOZU3V43GLNQWSFTIVPZTTS X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: tomi.ollila@iki.fi X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659293879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=PGRD1wsAewqcBdqqDvBOe+BsjtH5V6hv+F1q+spQJ6k=; b=Jjg1K3XSwQIIbl/yv62O6DwsHcmQEgpwKyUcsCEd/RFBjVl1OmEKCHtOD/dqQpuXt253Rm z/4fog65zY5zGK9PtLnOU+OXfNvEa+3GIN6/fUgtBxEmGPhrNZcmco2mDI181JZSMYQzHI TP898KzpmPkL3Qo53hFoM+LE1Qvd3HnkFzubSwDQnftCQ3l4upXuM3BVOCs9cDbO8oki0u pOBN13OErtiLR+YadpS6L7WB+7hE6yOzm8ajkLqiCtnYFNJJM0tNSJNKNQPrmwJVM5u3lG cItB62mE3F2oyMRPwACx87rnVfwG78vv98MRtHLYQcoWnK67sR8fjPPNA3IfAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659293879; a=rsa-sha256; cv=none; b=PZGgYb/CmLPpG3O+KtZReOYfGc7BoLo+wgSYdU2rg9/AbBnlb0qgVfPUiSdsGJsLs6ctqt fuvqYRM1379/NUvbHUby2VQx02SDFIdx5E3o7Vgah+n0oJojY2who90NFqiYN3t8VVRijy 4iOR/0SzzcrSMigy+uhoGw4lRpEg0CU30TMptKa8shs+K9Q1uTzF/15pqmz8fGx+YGcouG CL6Ej9QAI0ceUQg2zQk1wWkoaT3++Ho9pZts3hJpHgEBP1DvbD8XkXS1ewvhikC6JreTDs 9cG8YHQIWcbSCVUGDOGnJp+Sy3GZy1pHDl9huYiIAzN1IwGdf/Cx7oTo89vfsg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.27 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: BAE0F26722 X-Spam-Score: -2.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: vd3umbhMz7cp Tomi Ollila writes: > Removed duplicate error check (and the message) in 3rd case where > the same error message (w/o trailing newline) was present. > > In case of test/T040-setup.sh, command substitution deletes > trailing newlines, so related test there cannot be changed > (and therefore could not notice this user experience flaw). > --- > > The current error message can be experienced with > > $ NOTMUCH_CONFIG=no-cnfig-thre notmuch new > and (the second change, removed in this commit) > $ NOTMUCH_CONFIG=no-cnfig-thre notmuch config LGTM.